Closed Bug 1248339 Opened 5 years ago Closed 5 years ago

Fix header sort order of Hal.

Categories

(Core :: Hardware Abstraction Layer (HAL), defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla47
Tracking Status
firefox47 --- fixed

People

(Reporter: mantaroh, Assigned: mantaroh)

Details

Attachments

(1 file, 1 obsolete file)

In Hal directory, There are some file which unsorted include statements.

https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Coding_Style#CC_practices
Attached patch Fix header sort order of Hal. (obsolete) — Splinter Review
Assignee: nobody → mantaroh
Status: NEW → ASSIGNED
Thanks for doing this, just ask me for review whenever you feel the patch is ready.
Thanks gsvelto.

I fixed several code , and reconfirm on OSX.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=d0726d1865eb
Attachment #8719395 - Attachment is obsolete: true
Attachment #8719507 - Flags: review?(gsvelto)
Comment on attachment 8719507 [details] [diff] [review]
Fix header sort order of Hal.

Looks good to me, thanks!
Attachment #8719507 - Flags: review?(gsvelto) → review+
Thanks gsvelto!
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/a21fa8fc9d28
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla47
You need to log in before you can comment on or make changes to this bug.