Closed Bug 1248352 Opened 4 years ago Closed 4 years ago

js shell asserts on illegal option

Categories

(Core :: JavaScript Engine, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla47
Tracking Status
firefox47 --- fixed

People

(Reporter: lth, Assigned: jonco)

References

Details

Attachments

(1 file)

$ dist/bin/js --gczeal=2 ~/moz/ta.js
Error: Invalid long option: --gczeal=2

[[ Help text is printed ]]

Assertion failure: !isspace(*it), at /home/lhansen/moz/mozilla-inbound/js/src/shell/jsoptparse.cpp:98
Segmentation fault
Well, asserts -- but still not terribly desirable.
Summary: js shell segfaults on illegal option → js shell asserts on illegal option
It seems the option parsing code can't handle blank lines in help text.  This patch relaxes some assertions which makes things work, although the text is still slightly mangled.
Assignee: nobody → jcoppeard
Attachment #8723635 - Flags: review?(jdemooij)
Comment on attachment 8723635 [details] [diff] [review]
bug1248352-shell-help

Review of attachment 8723635 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks.
Attachment #8723635 - Flags: review?(jdemooij) → review+
https://hg.mozilla.org/mozilla-central/rev/f19129c21eb3
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla47
Duplicate of this bug: 1281094
You need to log in before you can comment on or make changes to this bug.