Make Valgrind Mochitests run greener on Taskcluster

RESOLVED FIXED in Firefox 53

Status

Testing
Mochitest
RESOLVED FIXED
2 years ago
a year ago

People

(Reporter: jseward, Assigned: jseward)

Tracking

Trunk
mozilla53
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox47 affected, firefox53 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

2 years ago
Bug 1245566 adds Taskcluster scheduling for Mochitests on Valgrind,
but such tests largely run Orange at the moment.  This bug tracks work
needed to get to an initial green state, so that such runs can be
scheduled for production.

The required changes are expected to be some combination of extra
suppressions and bug fixes.
(Assignee)

Updated

2 years ago
Blocks: 1245566
No longer depends on: 1245566
(Assignee)

Comment 1

2 years ago
Created attachment 8814405 [details] [diff] [review]
Suppressions and command-line-arg changes to reduce noise level

Without this patch, all 40 out of 40 mochitest tasks run orange on
taskcluster.  With it in place, at 19 out of 40 run green, for example
[1], and the remaining 21 do not have much noise.

The patch contains two components:

[a] new suppressions, largely for SSE functions to do with compositing

[b] A change of command line parameters:

    - so as not to trace into /usr/bin/lsb_release.  This runs Python,
      which creates a lot of noise because Valgrind doesn't interact well
      the Python implementation's memory management scheme.

    - changes the leak check report detail level from full to summary.
      This is because all runs report at least some leaks, and the 'full'
      mode printout makes the test harness orange-vs-not-orange detection
      always report "orange".  This isn't useful since we have other tools
      to detect leaks and it obscures runs which report uninitialised
      value errors, the detection of which is the main purpose of the runs.

Note that [a] affects both these new (mochitest-valgrind) runs and the
existing Valgrind short test in automation, although I don't think it
makes any difference to them because they don't report any of the
suppressed errors anyway.

Whereas [b] only applies to the new runs.  Flags for the existing
Valgrind short test are unaffected since they are set elsewhere.


[1]
https://treeherder.mozilla.org/#/jobs?repo=try&revision=f5f13828f59d9e401ad2b79f7eefefb5862df007
(Assignee)

Updated

2 years ago
Attachment #8814405 - Flags: review?(n.nethercote)
Comment on attachment 8814405 [details] [diff] [review]
Suppressions and command-line-arg changes to reduce noise level

Review of attachment 8814405 [details] [diff] [review]:
-----------------------------------------------------------------

::: testing/mozbase/mozdebug/mozdebug/mozdebug.py
@@ +285,5 @@
>  
>  
>  def get_default_valgrind_tool_specific_args():
>      return ['--partial-loads-ok=yes',
> +            '--leak-check=summary',

Should we just do --leak-check=no? The summary gives you just enough information to be worried but not enough to actually act... I'll let you decide.
Attachment #8814405 - Flags: review?(n.nethercote) → review+
(Assignee)

Updated

2 years ago
Summary: Make Valgrind Mochitests run green on Taskcluster → Make Valgrind Mochitests run greener on Taskcluster

Comment 3

2 years ago
Pushed by jseward@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/41a7afc03d20
Make Valgrind Mochitests run greener on Taskcluster.  r=n.nethercote.

Comment 4

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/41a7afc03d20
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox53: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla53

Updated

2 years ago
See Also: → bug 1321049
(Assignee)

Updated

a year ago
Depends on: 1334991
You need to log in before you can comment on or make changes to this bug.