1248380 - Raw Data view should wrap when data has no newlines

Status: RESOLVED FIXED

(DevTools :: JSON Viewer, defect, P3)

Description

[:Gijs (he/him)]

Looking at:

https://brasstacks.mozilla.com/orangefactor/api/bybug?startday=2015-12-01&endday=2016-02-15&bugid=1192153

it is just one massively long line of text.

Instead, the view should wrap - similar to how the data would look if you had turned off the JSON view.

Comment 1

[Joe Walker [:jwalker]]

Doing bug triage with Emma.
Filter on LOBSTER-THERMADOR

Comment 2

[Oriol Brufau [:Oriol]]

Attachment: json-wrap.patch

This is just white-space:pre-wrap

Also adding a bit of margin, otherwise wrapped text touches the screen side and it does not look nice.

Link in comment 0 needs credentials, I tested with https://hg.mozilla.org/mozilla-central/json-pushes?changeset=f8bdceb55c9d&full=1

Comment 3

[Oriol Brufau [:Oriol]]

Maybe text should only wrap in non-prettified JSON? Wrapping prettified JSON breaks the pretty indentations.

Comment 4

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Comment on attachment 8880195 [details] [diff] [review]
json-wrap.patch

Review of attachment 8880195 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good!

R+

Thanks
Honza

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/b7ab57751565
Wrap long lines in Raw Data view. r=Honza

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/b7ab57751565