1248382 - Document known partners in the in-tree docs

Status: RESOLVED FIXED

(Toolkit :: Telemetry, defect, P1)

Description

[Alessio Placitelli [:Dexter]]

We know that at least Ubuntu Firefox builds and Mozilla China repacks populate the parter info in the environment section with known values. We should document those.

Comment 1

[Hector Zhao [:hectorz]]

Values from Mozilla China repack:

{
  "distributionId": "MozillaOnline",
  "distributionVersion": "2015.12", <= this is the creation time of the installer used to install the current Firefox
  "partnerId": "mozillaonline",
  "distributor": "mozillaonline",
  "distributorChannel": "chinaedition",
  "partnerNames": ["mozillaonline"]
}

FYI, the distribution.ini files for Ubuntu[1], Yandex(Russia)[2] etc. repacks are available online.

[1]: http://bazaar.launchpad.net/~mozillateam/firefox/firefox.trusty/view/head:/debian/distribution.ini
[2]: http://hg.mozilla.org/build/partner-repacks/file/tip/partners/yandex-ru/distribution/distribution.ini

Comment 2

[Alessio Placitelli [:Dexter]]

Attachment: bug1248382.patch

Comment 3

[Alessio Placitelli [:Dexter]]

(In reply to Hector Zhao [:hectorz] from comment #1)
> Values from Mozilla China repack:

Thank you Hector!

Comment 4

[Georg Fritzsche [:gfritzsche]]

Comment on attachment 8722411 [details] [diff] [review]
bug1248382.patch

Review of attachment 8722411 [details] [diff] [review]:
-----------------------------------------------------------------

::: toolkit/components/telemetry/docs/environment.rst
@@ +311,5 @@
>  -------
>  
>  If the user is using a partner repack, this contains information identifying the repack being used, otherwise "partnerNames" will be an empty array and other entries will be null. The information may be missing when the profile just becomes available. In Firefox for desktop, the information along with other customizations defined in distribution.ini are processed later in the startup phase, and will be fully applied when "distribution-customization-complete" notification is sent.
>  
> +Some of known distribution identifiers are: "MozillaOnline" (Mozilla China repack), "canonical" (Ubuntu Firefox) and "yandex" (Firefox Build by Yandex).

Let's be specific about what property this is in and also add a link to the partner repacks:
http://hg.mozilla.org/build/partner-repacks/
I would make the known ones a list for readability.

Comment 5

[Alessio Placitelli [:Dexter]]

Attachment: bug1248382.patch

Comment 6

[Georg Fritzsche [:gfritzsche]]

Comment on attachment 8722489 [details] [diff] [review]
bug1248382.patch

Review of attachment 8722489 [details] [diff] [review]:
-----------------------------------------------------------------

::: toolkit/components/telemetry/docs/environment.rst
@@ +311,5 @@
>  -------
>  
>  If the user is using a partner repack, this contains information identifying the repack being used, otherwise "partnerNames" will be an empty array and other entries will be null. The information may be missing when the profile just becomes available. In Firefox for desktop, the information along with other customizations defined in distribution.ini are processed later in the startup phase, and will be fully applied when "distribution-customization-complete" notification is sent.
>  
> +Here is the value of the ``distributionId`` field for some of the known `partner repacks <http://hg.mozilla.org/build/partner-repacks/>`_:

Suggesting:
"Distributions are most reliably identified by the ``distributionId`` field.
Most partner information can be found in the `partner repacks <http://hg.mozilla.org/build/partner-repacks/>`_.
Important values include:
...

@@ +314,5 @@
>  
> +Here is the value of the ``distributionId`` field for some of the known `partner repacks <http://hg.mozilla.org/build/partner-repacks/>`_:
> +
> +- "MozillaOnline" for the Mozilla China repack.
> +- "canonical", for the Ubuntu Firefox repack.

Lets link to: http://bazaar.launchpad.net/~mozillateam/firefox/firefox.trusty/view/head:/debian/distribution.ini

Comment 7

[Alessio Placitelli [:Dexter]]

Attachment: bug1248382.patch

Comment 8

[Alessio Placitelli [:Dexter]]

https://hg.mozilla.org/integration/fx-team/rev/6ac3dbaeecde4a6d924f14023a1178caf806e6c7
Bug 1248382 - Document known partners. r=gfritzsche

Comment 9

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/6ac3dbaeecde

Comment 10

[Shane Caraveo (:mixedpuppy)]

FYI http://hg.mozilla.org/build/partner-repacks/ is deprecated and no longer used for builds.  The new location is on github and partner repacks are no longer public.  This is due to potential partners that need to remain private for a period of time.

Comment 11

[Hector Zhao [:hectorz]]

(In reply to Shane Caraveo (:mixedpuppy) from comment #10)
> FYI http://hg.mozilla.org/build/partner-repacks/ is deprecated and no longer
> used for builds.  The new location is on github and partner repacks are no
> longer public.  This is due to potential partners that need to remain
> private for a period of time.

Ah so that's why I cannot access the repack-scripts repo.

I intented to mention this in comment 1, but forgot to do so, sorry.