Document known partners in the in-tree docs

RESOLVED FIXED in Firefox 47

Status

()

Toolkit
Telemetry
P1
normal
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: Dexter, Assigned: Dexter)

Tracking

Trunk
mozilla47
Points:
1

Firefox Tracking Flags

(firefox47 fixed)

Details

(Whiteboard: [measurement:client])

Attachments

(1 attachment, 2 obsolete attachments)

(Assignee)

Description

2 years ago
We know that at least Ubuntu Firefox builds and Mozilla China repacks populate the parter info in the environment section with known values. We should document those.
(Assignee)

Updated

2 years ago
Blocks: 1216191
Points: --- → 1
Priority: -- → P3
Whiteboard: [measurement:client]
Priority: P3 → P1
Values from Mozilla China repack:

{
  "distributionId": "MozillaOnline",
  "distributionVersion": "2015.12", <= this is the creation time of the installer used to install the current Firefox
  "partnerId": "mozillaonline",
  "distributor": "mozillaonline",
  "distributorChannel": "chinaedition",
  "partnerNames": ["mozillaonline"]
}

FYI, the distribution.ini files for Ubuntu[1], Yandex(Russia)[2] etc. repacks are available online.

[1]: http://bazaar.launchpad.net/~mozillateam/firefox/firefox.trusty/view/head:/debian/distribution.ini
[2]: http://hg.mozilla.org/build/partner-repacks/file/tip/partners/yandex-ru/distribution/distribution.ini
(Assignee)

Comment 2

2 years ago
Created attachment 8722411 [details] [diff] [review]
bug1248382.patch
Assignee: nobody → alessio.placitelli
Status: NEW → ASSIGNED
Attachment #8722411 - Flags: review?(gfritzsche)
(Assignee)

Comment 3

2 years ago
(In reply to Hector Zhao [:hectorz] from comment #1)
> Values from Mozilla China repack:

Thank you Hector!
Comment on attachment 8722411 [details] [diff] [review]
bug1248382.patch

Review of attachment 8722411 [details] [diff] [review]:
-----------------------------------------------------------------

::: toolkit/components/telemetry/docs/environment.rst
@@ +311,5 @@
>  -------
>  
>  If the user is using a partner repack, this contains information identifying the repack being used, otherwise "partnerNames" will be an empty array and other entries will be null. The information may be missing when the profile just becomes available. In Firefox for desktop, the information along with other customizations defined in distribution.ini are processed later in the startup phase, and will be fully applied when "distribution-customization-complete" notification is sent.
>  
> +Some of known distribution identifiers are: "MozillaOnline" (Mozilla China repack), "canonical" (Ubuntu Firefox) and "yandex" (Firefox Build by Yandex).

Let's be specific about what property this is in and also add a link to the partner repacks:
http://hg.mozilla.org/build/partner-repacks/
I would make the known ones a list for readability.
Attachment #8722411 - Flags: review?(gfritzsche)
(Assignee)

Comment 5

2 years ago
Created attachment 8722489 [details] [diff] [review]
bug1248382.patch
Attachment #8722411 - Attachment is obsolete: true
Attachment #8722489 - Flags: review?(gfritzsche)
Comment on attachment 8722489 [details] [diff] [review]
bug1248382.patch

Review of attachment 8722489 [details] [diff] [review]:
-----------------------------------------------------------------

::: toolkit/components/telemetry/docs/environment.rst
@@ +311,5 @@
>  -------
>  
>  If the user is using a partner repack, this contains information identifying the repack being used, otherwise "partnerNames" will be an empty array and other entries will be null. The information may be missing when the profile just becomes available. In Firefox for desktop, the information along with other customizations defined in distribution.ini are processed later in the startup phase, and will be fully applied when "distribution-customization-complete" notification is sent.
>  
> +Here is the value of the ``distributionId`` field for some of the known `partner repacks <http://hg.mozilla.org/build/partner-repacks/>`_:

Suggesting:
"Distributions are most reliably identified by the ``distributionId`` field.
Most partner information can be found in the `partner repacks <http://hg.mozilla.org/build/partner-repacks/>`_.
Important values include:
...

@@ +314,5 @@
>  
> +Here is the value of the ``distributionId`` field for some of the known `partner repacks <http://hg.mozilla.org/build/partner-repacks/>`_:
> +
> +- "MozillaOnline" for the Mozilla China repack.
> +- "canonical", for the Ubuntu Firefox repack.

Lets link to: http://bazaar.launchpad.net/~mozillateam/firefox/firefox.trusty/view/head:/debian/distribution.ini
Attachment #8722489 - Flags: review?(gfritzsche) → review+
(Assignee)

Comment 7

2 years ago
Created attachment 8722562 [details] [diff] [review]
bug1248382.patch
Attachment #8722489 - Attachment is obsolete: true
Attachment #8722562 - Flags: review+

Comment 9

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/6ac3dbaeecde
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
status-firefox47: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla47
FYI http://hg.mozilla.org/build/partner-repacks/ is deprecated and no longer used for builds.  The new location is on github and partner repacks are no longer public.  This is due to potential partners that need to remain private for a period of time.
(In reply to Shane Caraveo (:mixedpuppy) from comment #10)
> FYI http://hg.mozilla.org/build/partner-repacks/ is deprecated and no longer
> used for builds.  The new location is on github and partner repacks are no
> longer public.  This is due to potential partners that need to remain
> private for a period of time.

Ah so that's why I cannot access the repack-scripts repo.

I intented to mention this in comment 1, but forgot to do so, sorry.
You need to log in before you can comment on or make changes to this bug.