1248419 - New review reports are not added in the moderated reviews queue

Status: VERIFIED FIXED

(Marketplace Graveyard :: Reviewer Tools, defect, P2)

Description

[Madalin Cotetiu]

Steps to reproduce:
1. Open an app all reviews page i.e: https://marketplace.allizom.org/app/bubble-shoot/ratings
2. Report a review.
3. Navigate to the moderated reviews queue: https://marketplace.allizom.org/reviewers/apps/queue/moderated/

Expected results:
The reported review is displayed in the moderated reviews queue.

Actual results:
The reported review is not displayed in the moderated reviews queue.

Notes/Issues:
Verified in FF47(Win7). Issue can be reproduced in mp-dev and mp-stage (I can't verify it in production as I do not have permissions in there)
Screencast for this issue:

Comment 1

[David Durst [:ddurst]]

Andrew -- can you confirm/deny this for prod? That will help us determine if it's already live or queued up for next tag.

Comment 2

[Andrew Williamson [:eviljeff]]

Unfortunately moderated reviews are sorted by flagging date and I can only see the first 20 (you can't paginate).  Short of moderating 1300 flagged reviews I can't confirm with a newly flagged one.  
Is checking the prod database enough?

Comment 3

[Madalin Cotetiu]

(In reply to Andrew Williamson [:eviljeff] from comment #2)
> Unfortunately moderated reviews are sorted by flagging date and I can only
> see the first 20 (you can't paginate).  Short of moderating 1300 flagged
> reviews I can't confirm with a newly flagged one.  
> Is checking the prod database enough?

I think partially you can confirm using a newly flagged review, if you report a new review and the number of total moderated reviews is incremented. That way at least we know that new moderated reviews are added.

Comment 4

[Andrew Williamson [:eviljeff]]

(In reply to Madalin Cotetiu from comment #3)
> (In reply to Andrew Williamson [:eviljeff] from comment #2)
> > Unfortunately moderated reviews are sorted by flagging date and I can only
> > see the first 20 (you can't paginate).  Short of moderating 1300 flagged
> > reviews I can't confirm with a newly flagged one.  
> > Is checking the prod database enough?
> 
> I think partially you can confirm using a newly flagged review, if you
> report a new review and the number of total moderated reviews is
> incremented. That way at least we know that new moderated reviews are added.

I just tried and the count hasn't increased.  However, its possible the reviews I flagged were already flagged (multiple users can flag the same review for removal) and the count is #reviews rather than #flags.  I tried adding a new review just to flag it but you can't flag your own review, heh.

So its probably confirmed as a real bug.

Comment 5

[Allen Short [:ashort]]

This was broken as a result of the restframework upgrade.
https://github.com/mozilla/zamboni/commit/dd79a1fd69e0d8d0b76a65f1e12a93784f99e56d

Comment 6

[Madalin Cotetiu]

Verified as fixed in FF45(Win7) in marketplace-dev.allizom.org
Screencast for this issue: http://screencast.com/t/p9jD2kNjqp