Magnifying glass icon in urlbar on about:home

VERIFIED FIXED in Firefox 47

Status

()

defect
VERIFIED FIXED
3 years ago
3 years ago

People

(Reporter: sebastian, Assigned: sebastian)

Tracking

unspecified
Firefox 47
All
Android
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox47 verified)

Details

Attachments

(2 attachments)

Posted image urlbar icons
about:home used a "magnifying glass" favicon. Now after we removed the favicon from the urlbar (bug 1018994) we just show the default site security icon. I assume we want to keep the magnifying glass, so we should replace the site security icon with it when showing about:home.
Comment on attachment 8719553 [details]
MozReview Request: Bug 1248437 - Replace site security icon with search icon on about:home. r=ahunt

https://reviewboard.mozilla.org/r/35003/#review32139

Looks good to me!

Note: this patch causes a merge-conflict for me, hg isn't able to take care of:
    // Icon used for about:home
    private final int LEVEL_SEARCH_ICON = 999;

So that will need fixing manually before pushing! (I'm not sure if there's any sane way to upload my locally fixed patch for this.)
Attachment #8719553 - Flags: review?(ahunt) → review+
Status: NEW → ASSIGNED
Attachment #8719553 - Attachment description: MozReview Request: Bug 1248437 - Replace site security icon with search icon on about:home. r?ahunt → MozReview Request: Bug 1248437 - Replace site security icon with search icon on about:home. r=ahunt
Comment on attachment 8719553 [details]
MozReview Request: Bug 1248437 - Replace site security icon with search icon on about:home. r=ahunt

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/35003/diff/1-2/
Comment on attachment 8719553 [details]
MozReview Request: Bug 1248437 - Replace site security icon with search icon on about:home. r=ahunt

@ahunt: I'll flag you for feedback because I changed the code a bit. The previous code exited updateSiteIdentity() early and therefore did not update the local state. This means if you switched to a different site and the state did not change then we still showed the search icon.
Attachment #8719553 - Flags: feedback?(ahunt)
https://reviewboard.mozilla.org/r/35003/#review33155

Yeah this looks good to me, sorry I didn't think that through!
Attachment #8719553 - Flags: feedback?(ahunt)

Comment 8

3 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/a1713c8c6746
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 47
Magnifying glass is displayed in URL Bar in about:home, so:
Verified as fixed using:
Device: Nexus 4 (Android 5.1.1) 
Build: Firefox for Android 47.0a1 (2016-02-29)

Comment 10

3 years ago
Based on comment 9 will mark the bug as verified.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.