Closed Bug 1248447 Opened 4 years ago Closed 4 years ago
Stop grafting prototypes in storage
.js::patch Metadata Maps And Protos()
MozReview Request: Bug 1248447 - Stop grafting prototypes in storage.js::patchMetadataMapsAndProtos() r?pbrosset
58 bytes, text/x-review-board-request
Doing bug triage with Emma. Filter on LOBSTER-THERMADOR
Priority: -- → P3
Review commit: https://reviewboard.mozilla.org/r/40795/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/40795/
4 years ago
Attachment #8731727 - Flags: review?(pbrosset)
Comment on attachment 8731727 [details] MozReview Request: Bug 1248447 - Stop grafting prototypes in storage.js::patchMetadataMapsAndProtos() r?pbrosset https://reviewboard.mozilla.org/r/40795/#review37851 I was not familiar with this part of the code before, and I'm not too sure what some of DatabaseMetadata does, but this looks like a simple change that helps with performance and gets rid of `__proto__`, which is good.
Attachment #8731727 - Flags: review?(pbrosset) → review+
https://hg.mozilla.org/integration/fx-team/rev/297bb754e23135fefc9683024bd33b7503427ee8 Bug 1248447 - Stop grafting prototypes in storage.js::patchMetadataMapsAndProtos() r+pbro
You need to log in before you can comment on or make changes to this bug.