Closed Bug 1248450 Opened 4 years ago Closed 4 years ago

Pass graphics error messages to the parent so that we see them in about:support

Categories

(Core :: Graphics, defect)

Unspecified
All
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla47
Tracking Status
firefox47 --- fixed

People

(Reporter: milan, Assigned: milan)

References

Details

(Keywords: feature)

Attachments

(1 file)

See bug 1247539 comment 1.  gfxCriticalError/Note and equivalent show up in about:support, but only when sent from the parent process.  When sent from the content process, they're not available to the API we have.

Crash reports should already be fine.
Assignee: nobody → milan
OS: Unspecified → All
Comment on attachment 8719552 [details]
MozReview Request: Bug 1248450: Send the graphics messages to the parent process. r=dvander

https://reviewboard.mozilla.org/r/34999/#review31623

::: dom/ipc/PContent.ipdl:1020
(Diff revision 1)
> +    sync GraphicsError(nsCString aError);

This should be async, unless there's a specific ordering problem you had in mind.
Attachment #8719552 - Flags: review?(dvander) → review+
(In reply to David Anderson [:dvander] from comment #2)
> ...
> 
> This should be async, unless there's a specific ordering problem you had in
> mind.

I kept thinking in the context of crashes, but, you're right, this is just for about:support, so it can wait.
Comment on attachment 8719552 [details]
MozReview Request: Bug 1248450: Send the graphics messages to the parent process. r=dvander

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/34999/diff/1-2/
Comment on attachment 8719552 [details]
MozReview Request: Bug 1248450: Send the graphics messages to the parent process. r=dvander

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/34999/diff/2-3/
https://hg.mozilla.org/mozilla-central/rev/22d0921df35a
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla47
You need to log in before you can comment on or make changes to this bug.