Pass graphics error messages to the parent so that we see them in about:support

RESOLVED FIXED in Firefox 47

Status

()

Core
Graphics
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: milan, Assigned: milan)

Tracking

({feature})

Trunk
mozilla47
Unspecified
All
feature
Points:
---
Bug Flags:
qe-verify -

Firefox Tracking Flags

(firefox47 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Assignee)

Description

2 years ago
See bug 1247539 comment 1.  gfxCriticalError/Note and equivalent show up in about:support, but only when sent from the parent process.  When sent from the content process, they're not available to the API we have.

Crash reports should already be fine.
(Assignee)

Updated

2 years ago
Blocks: 1247539
(Assignee)

Updated

2 years ago
Assignee: nobody → milan
OS: Unspecified → All
(Assignee)

Comment 1

2 years ago
Created attachment 8719552 [details]
MozReview Request: Bug 1248450: Send the graphics messages to the parent process. r=dvander

Review commit: https://reviewboard.mozilla.org/r/34999/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/34999/
Attachment #8719552 - Flags: review?(dvander)
Comment on attachment 8719552 [details]
MozReview Request: Bug 1248450: Send the graphics messages to the parent process. r=dvander

https://reviewboard.mozilla.org/r/34999/#review31623

::: dom/ipc/PContent.ipdl:1020
(Diff revision 1)
> +    sync GraphicsError(nsCString aError);

This should be async, unless there's a specific ordering problem you had in mind.
Attachment #8719552 - Flags: review?(dvander) → review+
(Assignee)

Comment 3

2 years ago
(In reply to David Anderson [:dvander] from comment #2)
> ...
> 
> This should be async, unless there's a specific ordering problem you had in
> mind.

I kept thinking in the context of crashes, but, you're right, this is just for about:support, so it can wait.
(Assignee)

Comment 4

2 years ago
Comment on attachment 8719552 [details]
MozReview Request: Bug 1248450: Send the graphics messages to the parent process. r=dvander

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/34999/diff/1-2/
(Assignee)

Updated

2 years ago
Keywords: feature
(Assignee)

Comment 5

2 years ago
Comment on attachment 8719552 [details]
MozReview Request: Bug 1248450: Send the graphics messages to the parent process. r=dvander

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/34999/diff/2-3/

Comment 7

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/22d0921df35a
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox47: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla47
Flags: qe-verify-
You need to log in before you can comment on or make changes to this bug.