Closed Bug 1248478 Opened 8 years ago Closed 8 years ago

Remove some obsolete code in XrayWrapper.cpp

Categories

(Core :: XPConnect, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla47
Tracking Status
firefox47 --- fixed

People

(Reporter: peterv, Assigned: peterv)

Details

(Whiteboard: dom-triaged btpp-active)

Attachments

(1 file)

Attached patch v1Splinter Review
We haven't supported non-WebIDL Window for a while (bug 1017424), but there's some code left for XPCWN Xrays for Window.
Attachment #8719593 - Flags: review?(bobbyholley)
Comment on attachment 8719593 [details] [diff] [review]
v1

Review of attachment 8719593 [details] [diff] [review]:
-----------------------------------------------------------------

\o/

I think we can probably actually just get rid of all XPCWN Xrays, given that it seems unlikely that any of the remaining XPCWN objects are used over Xray. If you have a moment, would you mind doing a try push to see what happens if we turn off XPCWN Xrays entirely?

r=me either way
Attachment #8719593 - Flags: review?(bobbyholley) → review+
Assignee: nobody → peterv
Whiteboard: dom-triaged btpp-active
https://hg.mozilla.org/mozilla-central/rev/cff999f3aee1
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla47
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: