Closed
Bug 1248492
Opened 7 years ago
Closed 7 years ago
Land version 1.1.2 of the Loop system add-on in mozilla-central
Categories
(Hello (Loop) :: Client, defect, P1)
Hello (Loop)
Client
Tracking
(firefox45 affected, firefox46 fixed, firefox47 fixed)
People
(Reporter: standard8, Assigned: standard8)
Details
Attachments
(2 files)
243.55 KB,
patch
|
Sylvestre
:
approval-mozilla-aurora+
Sylvestre
:
approval-mozilla-beta+
|
Details | Diff | Splinter Review |
228.43 KB,
patch
|
Sylvestre
:
approval-mozilla-aurora+
Sylvestre
:
approval-mozilla-beta+
|
Details | Diff | Splinter Review |
Since the last version that landed in mozilla-central we have: - Implemented a new FTU tour - Implemented cursor sharing from standalone to desktop (the other way was already present). - Improved prompts to share links on the conversation window - Various other fixes (see 1.1.0 -> 1.1.2 list of changes in https://github.com/mozilla/loop/blob/v1.1.2/CHANGELOG.md).
Assignee | ||
Comment 1•7 years ago
|
||
Just the locale updates imported from our repo.
Assignee | ||
Comment 2•7 years ago
|
||
The code changes.
Assignee | ||
Updated•7 years ago
|
Rank: 10
Assignee | ||
Comment 3•7 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/3409532948a3dd633c89dbb95a041f1de2360da3 Bug 1248492 - Land version 1.1.2 of the Loop system add-on in mozilla-central - locale updates. rs=Standard8 for already reviewed code https://hg.mozilla.org/integration/fx-team/rev/b2d75ac5ba0fc90ab7e58e81caff2e4b474f7ca9 Bug 1248492 - Land version 1.1.2 of the Loop system add-on in mozilla-central - code updates. rs=Standard8 for already reviewed code
Comment 4•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/3409532948a3 https://hg.mozilla.org/mozilla-central/rev/b2d75ac5ba0f
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox47:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla47
Assignee | ||
Comment 5•6 years ago
|
||
Comment on attachment 8719612 [details] [diff] [review] Land version 1.1.2 of the Loop system add-on in mozilla-central - locale updates. rs=Standard8 for already reviewed code Approval Request Comment [Feature/regressing bug #]: Firefox Hello [User impact if declined]: Various string fixes and improvements from localisers via the web process. [Describe test coverage new/current, TreeHerder]: Landed in m-c [Risks and why]: Low. Self-contained change for Loop only. [String/UUID change made/needed]: None (to Firefox process).
Attachment #8719612 -
Flags: approval-mozilla-beta?
Attachment #8719612 -
Flags: approval-mozilla-aurora?
Assignee | ||
Comment 6•6 years ago
|
||
Comment on attachment 8719613 [details] [diff] [review] Land version 1.1.2 of the Loop system add-on in mozilla-central - code updates. rs=Standard8 for already reviewed code Approval Request Comment [Feature/regressing bug #]: Firefox Hello [User impact if declined]: Lands the latest features to complete the release. [Describe test coverage new/current, TreeHerder]: Landed in m-c, code has tests. [Risks and why]: Low. Self-contained change for Loop only. [String/UUID change made/needed]: None
Attachment #8719613 -
Flags: approval-mozilla-beta?
Attachment #8719613 -
Flags: approval-mozilla-aurora?
Comment 7•6 years ago
|
||
Comment on attachment 8719613 [details] [diff] [review] Land version 1.1.2 of the Loop system add-on in mozilla-central - code updates. rs=Standard8 for already reviewed code As agreed, let's take it. 0.3.0 wasn't part of the previous beta
Attachment #8719613 -
Flags: approval-mozilla-beta?
Attachment #8719613 -
Flags: approval-mozilla-beta+
Attachment #8719613 -
Flags: approval-mozilla-aurora?
Attachment #8719613 -
Flags: approval-mozilla-aurora+
Updated•6 years ago
|
Attachment #8719612 -
Flags: approval-mozilla-beta?
Attachment #8719612 -
Flags: approval-mozilla-beta+
Attachment #8719612 -
Flags: approval-mozilla-aurora?
Attachment #8719612 -
Flags: approval-mozilla-aurora+
Assignee | ||
Comment 8•6 years ago
|
||
bugherderuplift |
https://hg.mozilla.org/releases/mozilla-aurora/rev/2f95370c985b https://hg.mozilla.org/releases/mozilla-aurora/rev/f575fc8331e7
status-firefox46:
--- → fixed
Assignee | ||
Comment 9•6 years ago
|
||
bugherderuplift |
https://hg.mozilla.org/releases/mozilla-beta/rev/ea7fdc1a8979 https://hg.mozilla.org/releases/mozilla-beta/rev/9c63a8b5db10
status-firefox45:
--- → fixed
Updated•6 years ago
|
Flags: qe-verify+
Comment 10•6 years ago
|
||
backed out by request from sylvestre in https://treeherder.mozilla.org/#/jobs?repo=mozilla-beta&revision=8bf2c5452d44
Flags: needinfo?(standard8)
Assignee | ||
Updated•6 years ago
|
Flags: needinfo?(standard8)
Comment 11•6 years ago
|
||
Since a new version is now available for Nightly by default I don't think this makes sense to be verified at this stage.
Flags: qe-verify+
You need to log in
before you can comment on or make changes to this bug.
Description
•