1248492 - Land version 1.1.2 of the Loop system add-on in mozilla-central

Status: RESOLVED FIXED

(Hello (Loop) :: Client, defect, P1)

Description

[Mark Banner (:standard8)]

Since the last version that landed in mozilla-central we have:

- Implemented a new FTU tour
- Implemented cursor sharing from standalone to desktop (the other way was already present).
- Improved prompts to share links on the conversation window
- Various other fixes (see 1.1.0 -> 1.1.2 list of changes in https://github.com/mozilla/loop/blob/v1.1.2/CHANGELOG.md).

Comment 1

[Mark Banner (:standard8)]

Attachment: Land version 1.1.2 of the Loop system add-on in mozilla-central - locale updates. rs=Standard8 for already reviewed code

Just the locale updates imported from our repo.

Comment 2

[Mark Banner (:standard8)]

Attachment: Land version 1.1.2 of the Loop system add-on in mozilla-central - code updates. rs=Standard8 for already reviewed code

The code changes.

Comment 3

[Mark Banner (:standard8)]

https://hg.mozilla.org/integration/fx-team/rev/3409532948a3dd633c89dbb95a041f1de2360da3
Bug 1248492 - Land version 1.1.2 of the Loop system add-on in mozilla-central - locale updates. rs=Standard8 for already reviewed code

https://hg.mozilla.org/integration/fx-team/rev/b2d75ac5ba0fc90ab7e58e81caff2e4b474f7ca9
Bug 1248492 - Land version 1.1.2 of the Loop system add-on in mozilla-central - code updates. rs=Standard8 for already reviewed code

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/3409532948a3
https://hg.mozilla.org/mozilla-central/rev/b2d75ac5ba0f

Comment 5

[Mark Banner (:standard8)]

Comment on attachment 8719612 [details] [diff] [review]
Land version 1.1.2 of the Loop system add-on in mozilla-central - locale updates. rs=Standard8 for already reviewed code

Approval Request Comment
[Feature/regressing bug #]: Firefox Hello
[User impact if declined]: Various string fixes and improvements from localisers via the web process.
[Describe test coverage new/current, TreeHerder]: Landed in m-c
[Risks and why]: Low. Self-contained change for Loop only.
[String/UUID change made/needed]: None (to Firefox process).

Comment 6

[Mark Banner (:standard8)]

Comment on attachment 8719613 [details] [diff] [review]
Land version 1.1.2 of the Loop system add-on in mozilla-central - code updates. rs=Standard8 for already reviewed code

Approval Request Comment
[Feature/regressing bug #]: Firefox Hello
[User impact if declined]: Lands the latest features to complete the release.
[Describe test coverage new/current, TreeHerder]: Landed in m-c, code has tests.
[Risks and why]: Low. Self-contained change for Loop only.
[String/UUID change made/needed]: None

Comment 7

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8719613 [details] [diff] [review]
Land version 1.1.2 of the Loop system add-on in mozilla-central - code updates. rs=Standard8 for already reviewed code

As agreed, let's take it. 0.3.0 wasn't part of the previous beta

Comment 8

[Mark Banner (:standard8)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/2f95370c985b
https://hg.mozilla.org/releases/mozilla-aurora/rev/f575fc8331e7

Comment 9

[Mark Banner (:standard8)]

https://hg.mozilla.org/releases/mozilla-beta/rev/ea7fdc1a8979
https://hg.mozilla.org/releases/mozilla-beta/rev/9c63a8b5db10

Comment 10

[Carsten Book [:Tomcat]]

backed out by request from sylvestre in https://treeherder.mozilla.org/#/jobs?repo=mozilla-beta&revision=8bf2c5452d44

Comment 11

[Bogdan Maris, Desktop Test Engineering]

Since a new version is now available for Nightly by default I don't think this makes sense to be verified at this stage.