1248497 - Add promise support to the sendMessage APIs.

Status: RESOLVED FIXED

(WebExtensions :: Untriaged, defect, P2)

Description

[Kris Maglione [:kmag]]

We should both return promises from the sendMessage functions, and allow the listener functions to return Promise objects, rather than `true`, to send a delayed response.

Comment 1

[Kris Maglione [:kmag]]

Attachment: MozReview Request: Bug 1248497 – Add promise support to the sendMessage APIs. r?billm

Review commit: https://reviewboard.mozilla.org/r/36979/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/36979/

Comment 2

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

Comment on attachment 8724322 [details]
MozReview Request: Bug 1248497 – Add promise support to the sendMessage APIs. r?billm

https://reviewboard.mozilla.org/r/36979/#review33805

::: browser/components/extensions/test/browser/browser_ext_tabs_sendMessage.js:24
(Diff revision 1)
> +              browser.test.fail("Got unexpected resposne callback");

response

Comment 3

[Kris Maglione [:kmag]]

https://hg.mozilla.org/integration/fx-team/rev/0a65c11157dac3a0940bd834a10bc3ff5702d2f2
Bug 1248497 – Add promise support to the sendMessage APIs. r=billm

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/0a65c11157da