1248530 - Link clicker pointer offset down when seen on the desktop client side

Status: RESOLVED FIXED

(Hello (Loop) :: Client, defect, P1)

Description

[Romain Testard [:RT]]

STR:
1 Generator creates and shares room
2 Clicker joins
3 Generator can see clicker pointer but it is represented lower than what is the true position on the clicker side

Comment 1

[Ed Lee :Mardak]

Can you take a screenshot? I wonder if it's for a particular aspect ratio or zoom. Is it incorrectly offset by some fixed amount -- perhaps the height of the notification bar?

Comment 2

[Mark Banner (:standard8)]

Fernando, please can you take a look at this with RT today?

Comment 3

[Romain Testard [:RT]]

Attachment: Capture d’écran 2016-02-16 à 13.14.24.png

Comment 4

[Romain Testard [:RT]]

Comment on attachment 8719746 [details]
Capture d’écran 2016-02-16 à 13.14.24.png

Pointer not captured on the screenshot

Comment 5

[Romain Testard [:RT]]

See the following video of the issue: http://g.recordit.co/FnN38KSZka.gif (the blue circle on the left if the link clicker pointer, the blue pointer on the right is how it gets represented.
There is a very noticeable vertical offset but also a small horizontal offset.

Comment 6

[Ed Lee :Mardak]

(In reply to Romain Testard [:RT] from comment #5)
> http://g.recordit.co/FnN38KSZka.gif
The pointer seems to be incorrectly offset by 45px, which visually seems to match the height of the top bar ("Firefox Hello" video/audio mute) in the new layout from bug 1238530.

mancas, any suggestions for fcampo on what might have changed this? I'm pretty sure the standalone -> desktop shared pointer was much closer when the patch was initially implemented, but a lot of things landed at the same time.

Comment 7

[Manuel Casas Barrado [:mancas]]

Perhaps could be caused by the padding added in the new link clicker UI?

Comment 8

[GitHub Autolander Bot]

Attachment: [loop] fcampo:pointer-offset-1248530 > mozilla:master

Comment 9

[Fernando Campo (:fcampo)]

Comment on attachment 8719858 [details] [review]
[loop] fcampo:pointer-offset-1248530 > mozilla:master

Indeed the infobar offset is the culprit.

I just added an offset calculation when the mousemove event is registered, I think it's better for the future than just subtract 40px.

Comment 10

[Ed Lee :Mardak]

Comment on attachment 8719858 [details] [review]
[loop] fcampo:pointer-offset-1248530 > mozilla:master

r=Mardak using getBoundingClientRect instead of implementing a custom _getOffset.

Comment 11

[Fernando Campo (:fcampo)]

merged - fa9b8b1ab0b7d3f27a80d939a2c45522187547ed

Comment 12

[Ed Lee :Mardak]

https://github.com/mozilla/loop/commit/fa9b8b1ab0b7d3f27a80d939a2c45522187547ed