Closed Bug 1248567 Opened 10 years ago Closed 10 years ago

Edit a room name from the panel

Categories

(Hello (Loop) :: Client, defect, P1)

Product:
Hello (Loop)
Component:
Client
Type:
defect

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: RT, Assigned: mancas)

References

Details

User Story

As a desktop client user, I want to edit a room name, so that my room list feels more intuitive.

Acceptance criteria:
- A new room option allows editing the room name
- Selecting the "Edit room name" option changes the room name to an editable field which allow the user to enter a new room name
- Pressing "Enter" or focussing somewhere else saves the edited room name

Attachments

(2 files)

[loop] mancas:bug1248567 > mozilla:master
40 bytes, text/x-github-pull-request
crafuse
: review+
Details | Review
DEMO
77 bytes, text/plain
Details
No description provided.
User Story: (updated)
Blocks: 1248602
Rank: 19
Priority: -- → P1
Assignee: nobody → b.mcb
Summary: Edit a room name from the panel → [Meta] Edit a room name from the panel
Attached file DEMO —
Attachment #8721942 - Flags: review?(edilee)
Attachment #8721942 - Flags: review?(crafuse)
Comment on attachment 8721942 [details] [review] [loop] mancas:bug1248567 > mozilla:master Looks good. r=chrafuse
Attachment #8721942 - Flags: review?(crafuse) → review+
Attachment #8721942 - Flags: review?(edilee)
RT, can we get rid of the [META] tag? this seems to be the final patch, it has no dependencies, and metas should be only containers that won't count for velocity tracking as we mentioned last week.
Flags: needinfo?(rtestard)
Sure, now done
Flags: needinfo?(rtestard)
Summary: [Meta] Edit a room name from the panel → Edit a room name from the panel
Landed in master: https://github.com/mozilla/loop/commit/f2a9fc1791309aafba85c28ce77a24d3cc987e77
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: