1248592 - Add an API endpoint for disabling autoland

Status: RESOLVED FIXED

(MozReview Graveyard :: General, defect)

Description

[Dan Minor [:dminor]]

To allow sheriffs to disable autoland, we should add an admin page to MozReview along with an associated permission which allows those settings to be edited.

Comment 1

[Steven MacLeod [:smacleod]]

(In reply to Dan Minor [:dminor] from comment #0)
> To allow sheriffs to disable autoland, we should add an admin page to
> MozReview along with an associated permission which allows those settings to
> be edited.

It would be much simpler to just add an API endpoint which can be hit to do this. Maybe we should start with that and then we could always build a front-end view for accessing this API later?

Comment 2

[Dan Minor [:dminor]]

Attachment: MozReview Request: mozreview: remove import pullrequest code (bug 1248592) r?smacleod

This no longer seems relevant now that we can push to review directly from
git. The corresponding autoland code was removed months ago. We can pull it
out from version control if for some reason we need to resurrect it.

Review commit: https://reviewboard.mozilla.org/r/37147/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/37147/

Comment 3

[Dan Minor [:dminor]]

Attachment: MozReview Request: mozreview: add API endpoint to enable/disable autoland (bug 1248592) r?smacleod

Review commit: https://reviewboard.mozilla.org/r/37149/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/37149/

Comment 4

[Steven MacLeod [:smacleod]]

Comment on attachment 8724765 [details]
MozReview Request: mozreview: remove import pullrequest code (bug 1248592) r?smacleod

https://reviewboard.mozilla.org/r/37147/#review34165

Comment 5

[Steven MacLeod [:smacleod]]

Comment on attachment 8724766 [details]
MozReview Request: mozreview: add API endpoint to enable/disable autoland (bug 1248592) r?smacleod

https://reviewboard.mozilla.org/r/37149/#review34167

::: pylib/mozreview/mozreview/autoland/resources.py:536
(Diff revision 1)
> +    @webapi_response_errors(DOES_NOT_EXIST, NOT_LOGGED_IN,

You never return a `NOT_LOGGED_IN` - are you seeing this coming from your resource? I'd have thought you'd need to decorate with `webapi_login_required` or something

::: pylib/mozreview/mozreview/autoland/resources.py:551
(Diff revision 1)
> +    @webapi_response_errors(DOES_NOT_EXIST, NOT_LOGGED_IN,

same with regards to `NOT_LOGGED_IN`

::: pylib/mozreview/mozreview/autoland/resources.py:567
(Diff revision 1)
> +

remove this blank line

::: pylib/mozreview/mozreview/autoland/resources.py:580
(Diff revision 1)
> +        logger.info('Setting autoland enable: repository %s: try: %s '
> +                    'landing: %s' % (kwargs[self.uri_object_key],
> +                    autolanding_to_try_enabled, autolanding_enabled))

should we stick the requesting user in here?

::: testing/vcttesting/mozreview.py:263
(Diff revision 1)
>          with futures.ThreadPoolExecutor(6) as e:

we maybe want to bump this to 7

Comment 6

[Dan Minor [:dminor]]

https://reviewboard.mozilla.org/r/37149/#review34167

> You never return a `NOT_LOGGED_IN` - are you seeing this coming from your resource? I'd have thought you'd need to decorate with `webapi_login_required` or something

It was accidentally cargo-culted from another resource.

Comment 7

[Dan Minor [:dminor]]

Comment on attachment 8724765 [details]
MozReview Request: mozreview: remove import pullrequest code (bug 1248592) r?smacleod

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/37147/diff/1-2/

Comment 8

[Dan Minor [:dminor]]

Comment on attachment 8724766 [details]
MozReview Request: mozreview: add API endpoint to enable/disable autoland (bug 1248592) r?smacleod

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/37149/diff/1-2/