1248637 - NrIceMediaStream::GetCandidatePairs does not prune out cancelled duplicates

Status: RESOLVED FIXED

(Core :: WebRTC: Networking, defect, P2)

Description

[Byron Campen [:bwc]]

This seems to be causing an intermittent failure in ice_unittest. We should probably prune out dupes earlier on.

Comment 1

[Byron Campen [:bwc]]

It seems that the problem is with duplicate CANCELLED pairs not being pruned out; we will prune a duplicate if there is a SUCCEEDED version of it only right now.

Comment 2

[Byron Campen [:bwc]]

Attachment: MozReview Request: Bug 1248637: Prune duplicate CANCELLED candidate pairs. r?drno

Review commit: https://reviewboard.mozilla.org/r/37401/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/37401/

Comment 3

[Nils Ohlmeier [:drno]]

Comment on attachment 8725279 [details]
MozReview Request: Bug 1248637: Prune duplicate CANCELLED candidate pairs. r?drno

https://reviewboard.mozilla.org/r/37401/#review33965

::: media/mtransport/nricemediastream.cpp:348
(Diff revision 1)
> +            ((p2->state != NR_ICE_PAIR_STATE_CANCELLED) &&
> +             (p1->state == NR_ICE_PAIR_STATE_CANCELLED))

So this will now consider e.g. a failed pair being better then the same canceled pair.
Another corner case is where everything is canceled, e.g. because the component got marked as failed. I think in that case we still report both pairs. But that is probably okay, as these two then are identical and will get reduced to one by the JS dict.

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/e55ea8c3f590

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/e55ea8c3f590