Closed Bug 1248637 Opened 4 years ago Closed 4 years ago
Ice Media Stream::Get Candidate Pairs does not prune out cancelled duplicates
58 bytes, text/x-review-board-request
This seems to be causing an intermittent failure in ice_unittest. We should probably prune out dupes earlier on.
backlog: --- → webrtc/webaudio+
Priority: -- → P2
It seems that the problem is with duplicate CANCELLED pairs not being pruned out; we will prune a duplicate if there is a SUCCEEDED version of it only right now.
Summary: UpdateAndValidateCandidatePairs in ice_unittest does not handle duplicate pairs (due to triggered checks) correctly → NrIceMediaStream::GetCandidatePairs does not prune out cancelled duplicates
Review commit: https://reviewboard.mozilla.org/r/37401/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/37401/
Attachment #8725279 - Flags: review?(drno)
Comment on attachment 8725279 [details] MozReview Request: Bug 1248637: Prune duplicate CANCELLED candidate pairs. r?drno https://reviewboard.mozilla.org/r/37401/#review33965 ::: media/mtransport/nricemediastream.cpp:348 (Diff revision 1) > + ((p2->state != NR_ICE_PAIR_STATE_CANCELLED) && > + (p1->state == NR_ICE_PAIR_STATE_CANCELLED)) So this will now consider e.g. a failed pair being better then the same canceled pair. Another corner case is where everything is canceled, e.g. because the component got marked as failed. I think in that case we still report both pairs. But that is probably okay, as these two then are identical and will get reduced to one by the JS dict.
Attachment #8725279 - Flags: review?(drno) → review+
You need to log in before you can comment on or make changes to this bug.