Closed
Bug 1248658
Opened 9 years ago
Closed 9 years ago
Remove make targets for running mochitests
Categories
(Firefox Build System :: General, defect)
Firefox Build System
General
Tracking
(firefox47 fixed)
RESOLVED
FIXED
mozilla47
Tracking | Status | |
---|---|---|
firefox47 | --- | fixed |
People
(Reporter: gps, Assigned: gps)
References
Details
Attachments
(1 file)
We've suggested mach as the mechanism to run tests for years. The old make targets for running mochitests are cruft and add overhead to maintain. Let's officially remove the make targets and unify behind mach commands.
Assignee | ||
Comment 1•9 years ago
|
||
These have been deprecated in favor of mach commands for years. Let's
stop pretending to support them by removing them.
Review commit: https://reviewboard.mozilla.org/r/35141/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/35141/
Assignee | ||
Updated•9 years ago
|
Attachment #8719857 -
Flags: review?(ted)
Updated•9 years ago
|
Attachment #8719857 -
Flags: review?(ted) → review+
Comment 2•9 years ago
|
||
Comment on attachment 8719857 [details]
MozReview Request: Bug 1248658 - Remove make targets for running mochitests; r?ted
https://reviewboard.mozilla.org/r/35141/#review31757
Whee!
Assignee | ||
Updated•9 years ago
|
Assignee: nobody → gps
Status: NEW → ASSIGNED
Assignee | ||
Comment 3•9 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/f3853089e25d5736022cd17c5a131ceb791b60d4
Bug 1248658 - Remove make targets for running mochitests; r=ted
Comment 4•9 years ago
|
||
Why not make the targets invoke mach?
Comment 5•9 years ago
|
||
Or print a message inviting to invoke mach. Because I can see people coming to complain that their commands don't work anymore and that they don't know how to run tests.
Assignee | ||
Comment 6•9 years ago
|
||
(In reply to Mike Hommey [:glandium] from comment #4)
> Why not make the targets invoke mach?
If enough people complain, we can consider that. But I'd rather we trend towards N=1 ways of doing things.
Assignee | ||
Comment 7•9 years ago
|
||
(In reply to Mike Hommey [:glandium] from comment #5)
> Or print a message inviting to invoke mach. Because I can see people coming
> to complain that their commands don't work anymore and that they don't know
> how to run tests.
I like this option even better, as I'd rather not continue support people running `make` for invoking tests. Let's see how many complaints there are before we take additional action.
Comment 8•9 years ago
|
||
We shouldn't want for people to complain when this could be fixed with 2 lines in that .mk file.
Comment 9•9 years ago
|
||
s/want/wait/
Comment 10•9 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox47:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla47
Updated•7 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•