Closed Bug 1248658 Opened 4 years ago Closed 4 years ago
Remove make targets for running mochitests
58 bytes, text/x-review-board-request
We've suggested mach as the mechanism to run tests for years. The old make targets for running mochitests are cruft and add overhead to maintain. Let's officially remove the make targets and unify behind mach commands.
These have been deprecated in favor of mach commands for years. Let's stop pretending to support them by removing them. Review commit: https://reviewboard.mozilla.org/r/35141/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/35141/
Attachment #8719857 - Flags: review?(ted) → review+
Comment on attachment 8719857 [details] MozReview Request: Bug 1248658 - Remove make targets for running mochitests; r?ted https://reviewboard.mozilla.org/r/35141/#review31757 Whee!
https://hg.mozilla.org/integration/mozilla-inbound/rev/f3853089e25d5736022cd17c5a131ceb791b60d4 Bug 1248658 - Remove make targets for running mochitests; r=ted
Why not make the targets invoke mach?
Or print a message inviting to invoke mach. Because I can see people coming to complain that their commands don't work anymore and that they don't know how to run tests.
(In reply to Mike Hommey [:glandium] from comment #4) > Why not make the targets invoke mach? If enough people complain, we can consider that. But I'd rather we trend towards N=1 ways of doing things.
(In reply to Mike Hommey [:glandium] from comment #5) > Or print a message inviting to invoke mach. Because I can see people coming > to complain that their commands don't work anymore and that they don't know > how to run tests. I like this option even better, as I'd rather not continue support people running `make` for invoking tests. Let's see how many complaints there are before we take additional action.
We shouldn't want for people to complain when this could be fixed with 2 lines in that .mk file.
You need to log in before you can comment on or make changes to this bug.