Remove make targets for running mochitests

RESOLVED FIXED in Firefox 47

Status

RESOLVED FIXED
3 years ago
8 months ago

People

(Reporter: gps, Assigned: gps)

Tracking

unspecified
mozilla47

Firefox Tracking Flags

(firefox47 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

3 years ago
We've suggested mach as the mechanism to run tests for years. The old make targets for running mochitests are cruft and add overhead to maintain. Let's officially remove the make targets and unify behind mach commands.
(Assignee)

Comment 1

3 years ago
Created attachment 8719857 [details]
MozReview Request: Bug 1248658 - Remove make targets for running mochitests; r?ted

These have been deprecated in favor of mach commands for years. Let's
stop pretending to support them by removing them.

Review commit: https://reviewboard.mozilla.org/r/35141/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/35141/
(Assignee)

Updated

3 years ago
Attachment #8719857 - Flags: review?(ted)
Attachment #8719857 - Flags: review?(ted) → review+
Comment on attachment 8719857 [details]
MozReview Request: Bug 1248658 - Remove make targets for running mochitests; r?ted

https://reviewboard.mozilla.org/r/35141/#review31757

Whee!
(Assignee)

Updated

3 years ago
Assignee: nobody → gps
Status: NEW → ASSIGNED
Why not make the targets invoke mach?
Or print a message inviting to invoke mach. Because I can see people coming to complain that their commands don't work anymore and that they don't know how to run tests.
(Assignee)

Comment 6

3 years ago
(In reply to Mike Hommey [:glandium] from comment #4)
> Why not make the targets invoke mach?

If enough people complain, we can consider that. But I'd rather we trend towards N=1 ways of doing things.
(Assignee)

Comment 7

3 years ago
(In reply to Mike Hommey [:glandium] from comment #5)
> Or print a message inviting to invoke mach. Because I can see people coming
> to complain that their commands don't work anymore and that they don't know
> how to run tests.

I like this option even better, as I'd rather not continue support people running `make` for invoking tests. Let's see how many complaints there are before we take additional action.
We shouldn't want for people to complain when this could be fixed with 2 lines in that .mk file.
s/want/wait/

Comment 10

3 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/f3853089e25d
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
status-firefox47: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla47
(Assignee)

Updated

3 years ago
Blocks: 1251325

Updated

8 months ago
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.