1248676 - [autolander] Upgrade treeherder-node client to 0.7.0

Status: RESOLVED INCOMPLETE

(Firefox OS Graveyard :: Gaia::GithubBot, defect)

Description

[Ed Morley [:emorley]]

To pick up bug 1191403.

Comment 1

[GitHub Autolander Bot]

Attachment: [autolander] edmorley:mozilla-treeherder-0.7.0 > mozilla:master

Comment 2

[Greg Arndt [:garndt]]

Comment on attachment 8719872 [details] [review]
[autolander] edmorley:mozilla-treeherder-0.7.0 > mozilla:master

Hrm, This might break things.  I have never hacked on autolander, but I know that somewhere in those version of the treeherder client we switched to using hawk auth rather than per project oauth.  I don't think autolander was ever updated to use that.  I'm not sure who owns that project.

For that reason, I'm inclined to r- this until someone owns this and knows for sure.

Comment 3

[Ed Morley [:emorley]]

Ah I meant to ask Kevin for review, I got mixed up, sorry!

Ah I thought autolander was only using the fetching parts of mozilla-treeherder, however in fact it only posts to Treeherder. However non-hawk auth was removed a few months ago, so this can't actually be enabled or is deadcode:

https://github.com/mozilla/autolander/blob/581655ecbeddad734bec86887f6b548694ed935f/lib/taskgraph.js#L130-L144

Kevin, can you shed some light on this? :-)

Comment 4

[Ed Morley [:emorley]]

Sorry that could have been clearer:

I'm wanting to try and make as many consumers of Treeherder's API set a user agent as possible. The node client (mozilla-treeherder) has been updated to set a UA, and this bug is for making autolander use this new version. However it seems that perhaps autolander isn't actually using it after all, since the auth would fail if it were (since Treeherder has in the meantime removed support for the old style auth used in autolander at present).

Comment 5

[Kevin Grandon :kgrandon]

(In reply to Ed Morley [:emorley] from comment #3)
> Ah I meant to ask Kevin for review, I got mixed up, sorry!
> 
> Ah I thought autolander was only using the fetching parts of
> mozilla-treeherder, however in fact it only posts to Treeherder. However
> non-hawk auth was removed a few months ago, so this can't actually be
> enabled or is deadcode:
> 
> https://github.com/mozilla/autolander/blob/
> 581655ecbeddad734bec86887f6b548694ed935f/lib/taskgraph.js#L130-L144
> 
> Kevin, can you shed some light on this? :-)

Autolander used to post treeherder jobs to run tests on pull requests. At the time it was only enabled on Gaia, but has since been disabled and not re-enabled. Right now there are no consumers of this and that code path is probably not being hit.

You can probably go ahead with your change. I'd leave the old code in there in case we ever get around to fixing it, but maybe with a comment to explain what needs to be updated.

Comment 6

[Ed Morley [:emorley]]

Thank you. Since this disabled feature was the only user of the mozilla-treeherder client, there's not an urgent need to land this, since autolander isn't making requests to Treeherder anyway. As such, I'll leave this as-is for now :-)