Closed
Bug 1248710
Opened 8 years ago
Closed 8 years ago
Add a User Agent to requests that web-platform fetchlogs.py makes to Treeherder
Categories
(Testing :: web-platform-tests, defect)
Testing
web-platform-tests
Tracking
(firefox47 fixed)
RESOLVED
FIXED
mozilla47
| Tracking | Status | |
|---|---|---|
| firefox47 | --- | fixed |
People
(Reporter: emorley, Assigned: emorley)
References
Details
Attachments
(1 file)
|
4.60 KB,
patch
|
jgraham
:
review+
|
Details | Diff | Splinter Review |
In bug 1230222 we're wanting to have consumers of Treeherder's API set a User Agent, to make issues (or eg deprecation of a particular endpoint) easier to track.
|
Assignee | |
Comment 1•8 years ago
|
||
Attachment #8719917 -
Flags: review?(james)
|
||
Comment 2•8 years ago
|
||
Comment on attachment 8719917 [details] [diff] [review] Add a User Agent to fetchlogs.py's requests to Treeherder Review of attachment 8719917 [details] [diff] [review]: ----------------------------------------------------------------- It seems like maybe you converted the file to Windows line endings? This might just be an artifact of your version control doing automatic conversions ofc. In any case please ensure that the committed file doesn't change. Otherwise, looks good; thanks for doing this.
Attachment #8719917 -
Flags: review?(james) → review+
|
|
Assignee | |
Comment 3•8 years ago
|
||
Yeah my editor is very much LF only, there must be something up with my hgrc (I so rarely use Mercurial these days). remote: https://hg.mozilla.org/integration/mozilla-inbound/rev/2ca3549fe569
|
||
Comment 4•8 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/2ca3549fe569
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox47:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla47
You need to log in
before you can comment on or make changes to this bug.
Description
•