1248719 - Taking ownership of error reporting on an AutoJSAPI inited without a global on a worker is not ok

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Boris Zbarsky [:bzbarsky]]

AutoJSAPI::Init() with no args calls InitInternal() with a null aGlobal, which puts mAutoNullableCompartment in the null compartment.  Then in AutoJSAPI::ReportException we would end up hitting this code:

509   JS::Rooted<JSObject*> errorGlobal(cx(), JS::CurrentGlobalOrNull(cx()));
510   if (!errorGlobal)
511     errorGlobal = xpc::PrivilegedJunkScope();

which is clearly not OK on a worker.

Comment 1

[Boris Zbarsky [:bzbarsky]]

Attachment: Fix things so that taking ownership of error reporting on an AutoJSAPI on a worker is OK even if that AutoJSAPI was initialized without an explicit global

Comment 2

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/f515b1ee11e2

Comment 3

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/f515b1ee11e2