1248764 - Enable Adjust on all release channels

Status: NEW

(Firefox Build System :: Android Studio and Gradle Integration, defect)

Description

[Nick Alexander :nalexander [he/him]]

Bug 1233238 (and fallout from it) hit for a few reasons:

1) we build and deploy Adjust only on Release and Beta, so the build issues weren't spotted by our early testers;

2) we bucket Release and Beta together.  Release is orders of magnitude larger than Beta, so we didn't see the drop in Beta data at all, so we didn't spot the real issues until Release shipped.

Bug 1248066 is splitting the Release and Beta buckets, but glandium raises a good point: we should try not to have things change between release channels.  To that end, let's enable Adjust install tracking on all release channels.  That would mean turning it on for Aurora, Nightly, and custom builds.  (We'll bucket everything separately, since Adjust doesn't let us differentiate our release channels (Android application ids).

Comment 1

[Nick Alexander :nalexander [he/him]]

margaret: mfinkle: When we landed Adjust in Bug 1143888, we took landing on Release/Beta as a given -- see https://bugzilla.mozilla.org/show_bug.cgi?id=1143888#c0 point 2) -- but I don't know why that is so.

Is there a legal reason to not simplify our code and release process?

Comment 2

[:Margaret Leibovic]

(In reply to Nick Alexander :nalexander from comment #1)
> margaret: mfinkle: When we landed Adjust in Bug 1143888, we took landing on
> Release/Beta as a given -- see
> https://bugzilla.mozilla.org/show_bug.cgi?id=1143888#c0 point 2) -- but I
> don't know why that is so.
> 
> Is there a legal reason to not simplify our code and release process?

I assume we did this as part of our "collect minimal data" policy. We didn't have a need for tracking paid installs for Nightly/Aurora, so we didn't include this. However, since that bug, we now use Adjust to track DAU/MAU, so I feel like it would actually be useful to have it for Nightly/Aurora.

I also think the argument for testing to avoid bustage on release is a strong enough argument in and of itself.

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

I agree with Maragret. I don't see any reason not to send the current set of minimal data to Adjust for Nightly and Aurora.