Closed
Bug 1248840
Opened 9 years ago
Closed 9 years ago
rename TreeWalker::NextChild
Categories
(Core :: Disability Access APIs, defect)
Core
Disability Access APIs
Tracking
()
RESOLVED
FIXED
mozilla47
| Tracking | Status | |
|---|---|---|
| firefox47 | --- | fixed |
People
(Reporter: surkov, Assigned: surkov)
Details
Attachments
(1 file)
|
7.11 KB,
patch
|
yzen
:
review+
|
Details | Diff | Splinter Review |
we indeed use TreeWalker to traverse children, but various combinations of context and anchor may give results from the subtree. Also TreeWalker name itself says nothing about children traversal. Note, internal TreeWalker methods don't have 'Child' in names.
Attachment #8720090 -
Flags: review?(yzenevich)
|
||
Comment 1•9 years ago
|
||
Comment on attachment 8720090 [details] [diff] [review]
patch
Review of attachment 8720090 [details] [diff] [review]:
-----------------------------------------------------------------
looks good , thanks
Attachment #8720090 -
Flags: review?(yzenevich) → review+
|
Assignee | |
Comment 2•9 years ago
|
||
|
|
Assignee | |
Comment 3•9 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/7ba85f7d6c961de5717334259fc4c320c1c4dd1f
Bug 1248840 - rename TreeWalker::NextChild, r=yzen
|
||
Comment 4•9 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox47:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla47
You need to log in
before you can comment on or make changes to this bug.
Description
•