Closed Bug 1248840 Opened 5 years ago Closed 5 years ago

rename TreeWalker::NextChild

Categories

(Core :: Disability Access APIs, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla47
Tracking Status
firefox47 --- fixed

People

(Reporter: surkov, Assigned: surkov)

Details

Attachments

(1 file)

Attached patch patchSplinter Review
we indeed use TreeWalker to traverse children, but various combinations of context and anchor may give results from the subtree. Also TreeWalker name itself says nothing about children traversal. Note, internal TreeWalker methods don't have 'Child' in names.
Attachment #8720090 - Flags: review?(yzenevich)
Comment on attachment 8720090 [details] [diff] [review]
patch

Review of attachment 8720090 [details] [diff] [review]:
-----------------------------------------------------------------

looks good , thanks
Attachment #8720090 - Flags: review?(yzenevich) → review+
https://hg.mozilla.org/mozilla-central/rev/7ba85f7d6c96
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla47
Blocks: 1256260
No longer blocks: 1256260
You need to log in before you can comment on or make changes to this bug.