Closed Bug 1248843 Opened 4 years ago Closed 4 years ago

Make it clearer that DebugOnly uses up space even in optimized, non-DEBUG builds

Categories

(Core :: MFBT, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla47
Tracking Status
firefox47 --- fixed

People

(Reporter: jwatt, Assigned: jwatt)

Details

Attachments

(1 file)

No description provided.
Attached patch patchSplinter Review
Attachment #8720108 - Flags: review?(jwalden+bmo)
Comment on attachment 8720108 [details] [diff] [review]
patch

Review of attachment 8720108 [details] [diff] [review]:
-----------------------------------------------------------------

One of these days, this limitation (and the limitation that |DO<T> = ...;| evaluates |...| in all builds, which some people don't think through that far to realize) will be reason enough to kill off DebugOnly.  I hope that day arrives soon.
Attachment #8720108 - Flags: review?(jwalden+bmo) → review+
> One of these days, this limitation will be reason enough to kill off DebugOnly.

Yes, please.  I think it's a constant source of confusion for everyone.
https://hg.mozilla.org/mozilla-central/rev/083181144d01
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla47
You need to log in before you can comment on or make changes to this bug.