Baldr: change function bodies to an expr list from expr

RESOLVED FIXED in Firefox 47

Status

()

Core
JavaScript Engine
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: luke, Assigned: luke)

Tracking

unspecified
mozilla47
Points:
---

Firefox Tracking Flags

(firefox47 fixed)

Details

Attachments

(3 attachments)

(Assignee)

Description

2 years ago
The AST has function bodies being an expr list:
  https://github.com/WebAssembly/spec/blob/master/ml-proto/spec/ast.ml#L207
but currently they're just an expr.
(Assignee)

Comment 1

2 years ago
Created attachment 8720133 [details] [diff] [review]
mv-compile-args

This is convenient for the next patch and avoids the ad hoc passing of CompileArgs.
Attachment #8720133 - Flags: review?(bbouvier)
(Assignee)

Comment 2

2 years ago
Created attachment 8720134 [details] [diff] [review]
rm-interrupt-check

This patch removes the non-wasm interrupt opcodes so we don't have to worry about them in the next patch.
Attachment #8720134 - Flags: review?(bbouvier)
(Assignee)

Comment 3

2 years ago
Created attachment 8720135 [details] [diff] [review]
body-is-a-list

You may recognize parts of this patch :)  Note that this time the body is an 'expr list' which is almost like a block but no Expr::Block opcode.
Attachment #8720135 - Flags: review?(bbouvier)
Comment on attachment 8720134 [details] [diff] [review]
rm-interrupt-check

Review of attachment 8720134 [details] [diff] [review]:
-----------------------------------------------------------------

\o/
Attachment #8720134 - Flags: review?(bbouvier) → review+
Attachment #8720133 - Flags: review?(bbouvier) → review+
Attachment #8720135 - Flags: review?(bbouvier) → review+

Comment 6

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/185f8e002c0e
https://hg.mozilla.org/mozilla-central/rev/c4d7e7b3172f
https://hg.mozilla.org/mozilla-central/rev/6bb9aa94a48e
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
status-firefox47: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla47
You need to log in before you can comment on or make changes to this bug.