Closed Bug 1248896 Opened 4 years ago Closed 4 years ago

No conditional compilation with ENABLE_TESTS in Nuwa


(Core :: IPC, defect)

Not set



Tracking Status
firefox46 - fixed
firefox47 --- fixed


(Reporter: cyu, Assigned: cyu)




(1 file)

See bug 1248590. We don't want to #ifdef ENABLE_TESTS in performing tests in Nuwa.
Attachment #8720197 - Flags: review?(khuey)
Comment on attachment 8720197 [details] [diff] [review]
Remove ENABLE_TESTS in Nuwa

Review of attachment 8720197 [details] [diff] [review]:

We specifically did this because b2g has no debug testing, but I don't care about b2g anymore, so w/e.
Attachment #8720197 - Flags: review?(khuey) → review+
Component: Release Automation → IPC
Product: Release Engineering → Core
QA Contact: bhearsum
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla47
[Tracking Requested - why for this release]: I would like to uplift this to aurora so firefox 46 can take advantage of build promotion (bug 1248590)
Comment on attachment 8720197 [details] [diff] [review]
Remove ENABLE_TESTS in Nuwa

Approval Request Comment
[Feature/regressing bug #]: 1248590
[User impact if declined]: N/A
[Describe test coverage new/current, TreeHerder]: code exists in debug only, not for opt/pgo with ENABLE_TESTS defined
[Risks and why]: I can't think of any- possibly we (or someone else) is somehow shipping this code with ENABLE_TESTS in release mode and has a dependency on these test api's
[String/UUID change made/needed]: N/A
Attachment #8720197 - Flags: approval-mozilla-aurora?
Comment on attachment 8720197 [details] [diff] [review]
Remove ENABLE_TESTS in Nuwa

Build promote all the things. OK to uplift.
Attachment #8720197 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
I don't think we need to track this, releng and joel will notice if there are problems, and we can see the dependencies from bug 1248590 .
You need to log in before you can comment on or make changes to this bug.