1248923 - Update ParamTraits<GonkNativeHandle>::Read()

Status: RESOLVED FIXED

(Core :: Graphics: Layers, defect)

Description

[Sotaro Ikeda [:sotaro]]

ParamTraits<GonkNativeHandle>::Read() does not set a result. Needs to address it.

Comment 1

[Sotaro Ikeda [:sotaro]]

Attachment: patch - Store result in Update ParamTraits<GonkNativeHandle>::Read()

Comment 2

[Nicolas Silva [:nical]]

Comment on attachment 8720235 [details] [diff] [review]
patch - Store result in Update ParamTraits<GonkNativeHandle>::Read()

Review of attachment 8720235 [details] [diff] [review]:
-----------------------------------------------------------------

::: gfx/layers/ipc/GonkNativeHandleUtils.cpp
@@ +62,5 @@
>      nativeHandle->data[i] = fd.fd;
>    }
>  
> +  GonkNativeHandle handle(new GonkNativeHandle::NhObj(nativeHandle));
> +  handle.TransferToAnother(*aResult);  

nit: trailing spaces

Comment 3

[Sotaro Ikeda [:sotaro]]

Attachment: patch - Store result in Update ParamTraits<GonkNativeHandle>::Read()

Apply the comment. Carry "r=nical".

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/7f6575cf223e

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/7f6575cf223e