124895 - Improper definition of NS_PROMPTSERVICE_CID

Status: VERIFIED FIXED

(Core Graveyard :: File Handling, defect)

Description

[timeless]

41 #define NS_PROMPTSERVICE_CID 
	"@mozilla.org/embedcomp/prompt-service;1"

http://lxr.mozilla.org/seamonkey/source/embedding/components/windowwatcher/src/nsPromptService.h#43

42 // {A2112D6A-0E28-421f-B46A-25C0B308CBD0}
43 #define NS_PROMPTSERVICE_CID \
44  {0xa2112d6a, 0x0e28, 0x421f, {0xb4, 0x6a, 0x25, 0xc0, 0xb3, 0x8, 0xcb, 0xd0}}
45 #define NS_PROMPTSERVICE_CONTRACTID \
46  "@mozilla.org/embedcomp/prompt-service;1"

Comment 1

[Alec Flett]

how about some english 

Comment 2

[Simon Fraser [no longer active]]

pchen ain't here no mo'.

I think timeless is noting a conflict between two #defines of 
NS_PROMPTSERVICE_CID.

Comment 3

[Alec Flett]

where is this conflict? I can't read this timeless-speak, what I see looks ok to me.

Comment 4

[Simon Fraser [no longer active]]

41 #define NS_PROMPTSERVICE_CID 
        "@mozilla.org/embedcomp/prompt-service;1"

(which happens in a bunch of places:
<http://lxr.mozilla.org/seamonkey/search?string=NS_PROMPTSERVICE_CID%20>
)

and

42 // {A2112D6A-0E28-421f-B46A-25C0B308CBD0}
43 #define NS_PROMPTSERVICE_CID \
44  {0xa2112d6a, 0x0e28, 0x421f, {0xb4, 0x6a, 0x25, 0xc0, 0xb3, 0x8, 0xcb, 0xd0}}

Comment 5

[timeless]

In all the other cases the _CID is a Class ID, in this case, _CID is a string
(contractid).

Comment 6

[timeless]

Attachment: rename the mac/nsOSHelperAppService.cpp NS_PROMPTSERVICE_CID to NS_PROMPTSERVICE_CONTRACTID

Comment 7

[Alec Flett]

Comment on attachment 68910 [details] [diff] [review]
rename the mac/nsOSHelperAppService.cpp NS_PROMPTSERVICE_CID to NS_PROMPTSERVICE_CONTRACTID

ah ok. sr=alecf

Comment 8

[Simon Fraser [no longer active]]

What about the other ones?

Comment 9

[timeless]

The other ones are alternative implementations of the promptservice. The fact that they share a ClassID is probably similar to the way that nsLocalFile* share a ClassID. Since you can never have more than one of them it's ok...

I'm not authoritative in that area, CCarlen/DanM/AdamLock can correct me.

Comment 10

[Dan M]

All other uses of NS_PROMPTSERVICE_CID in the codebase are legitimate CIDs used
for declaring the service (either the default or some embedding override). It's
unfortunate that that CID needs to be redeclared. See bug 124915.

Comment 11

[timeless]

fixed

Comment 12

[Chris Petersen]

Verified..