1249030 - No tooltip for help button from standalone Hello infobar

Status: RESOLVED FIXED

(Hello (Loop) :: Client, defect, P2)

Description

[Bogdan Maris, Desktop Test Engineering]

Attachment: Gif showing the issue

[Affected versions]:
- Firefox 44.0
- Firefox 45 beta 6
- Latest Aurora 46.0a2
- Latest Nightly 47.0a1

[Affected platforms]:
- Mac OS X 10.10.5
- Ubuntu 14.04 32-bit
- Windows 10 64-bit

[Steps to reproduce]:
1. Start Firefox
2. Change the loop.server to https://loop-dev.stage.mozaws.net/v0 in about:config
3. Restart Firefox
4. Start a conversation
5. Join the conversation from another browser/PC
6. In standalone hover over the help ('?') icon

[Expected result]:
- A tooltip appears letting the user know what button does.

[Actual result]:
- No tooltip is displayed.

[Regression range]:
- Unable to find a regression range because this affects Standalone only.

[Additional notes]:
- Gif attached showing the issue

Comment 1

[David Critchley (:dcritch)]

What should this tooltip say?

Comment 2

[Sevaan Franks [:sevaan]]

(In reply to David Critchley (:dcritch) from comment #1)
> What should this tooltip say?

I think just "Help" works.

Comment 3

[GitHub Autolander Bot]

Attachment: [loop] daveccrit:1249030-noTooltip > mozilla:master

Comment 4

[David Critchley (:dcritch)]

Attachment: Link to Github pull-request: https://github.com/mozilla/loop/pull/232

Comment 5

[Manuel Casas Barrado [:mancas]]

Looks good for me. r=me .Don't forget to add the reviewer to the commit. Also Travis is failing but not seems to be fault of your code, perhaps :Standard8 or :dmose could tell us why it's failing.

Comment 6

[Dan Mosedale (:dmosedale, :dmose)]

Looks to me like a travis infrastructure problem.  I've restarted that build: 

https://travis-ci.org/mozilla/loop/builds/113254034

If you log in to travis with github, you may be able to restart builds yourselves, or it may be that Standard8 needs to add some permission bit for that (I couldn't immediately see how to do it).

Comment 7

[Mark Banner (:standard8)]

Someone stopped producing 32 bit builds of Chromium for Debian and as a result upset our travis builds.

That's fixed now - just rebase on top of latest master, and force push to the PR - then check the results are still green, then you can push to master ;-)

Comment 8

[David Critchley (:dcritch)]

oops, sorry... realized after that I put r=standard8 in the commit message, should have been r=mancas