Closed Bug 1249036 Opened 5 years ago Closed 5 years ago

Locking up in WinUtils::dwmGetCompositionTimingInfoPtr


(Core :: Graphics, defect)

Not set



Tracking Status
firefox46 --- fixed
firefox47 --- fixed


(Reporter: mconley, Assigned: mchang)



(3 files, 1 obsolete file)

I've been hitting this off and on for a few days - suddenly, my Nightly will become completely unresponsive, and then I'll get the "process not responding" spinner from Windows, and I have to manually kill the process.

Today, I made sure I had the right revision checked out of mozilla-central for the build I was running, and once I locked up, got a stack:

>	dwmapi.dll!CPortClient::SendComplexSyncRequestNative(unsigned long,void const *,short,void *,short,long *)	Unknown
 	dwmapi.dll!CPortClient::SendComplexSyncRequest(unsigned long,void const *,short,void *,short,long *)	Unknown
 	dwmapi.dll!CApiPortClient::SendRequest(void const *,short,long *,void *,short)	Unknown
 	dwmapi.dll!DwmFlush()	Unknown
 	xul.dll!D3DVsyncSource::D3DVsyncDisplay::VBlankLoop() Line 2763	C++
 	xul.dll!RunnableMethod<mozilla::ipc::MessageChannel,void (__cdecl mozilla::ipc::MessageChannel::*)(void) __ptr64,mozilla::Tuple<> >::Run() Line 308	C++
 	xul.dll!MessageLoop::DoWork() Line 459	C++
 	xul.dll!base::MessagePumpDefault::Run(base::MessagePump::Delegate * delegate) Line 35	C++
 	xul.dll!MessageLoop::RunHandler() Line 228	C++
 	xul.dll!MessageLoop::Run() Line 202	C++
 	xul.dll!base::Thread::ThreadMain() Line 175	C++
 	xul.dll!`anonymous namespace'::ThreadFunc(void * closure) Line 27	C++

So apparently I was locking up here:
Hit this thing twice today now.

Here's my about:support:

Application Basics

Name: Firefox
Version: 47.0a1
Build ID: 20160217030229
Update Channel: nightly
User Agent: Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:47.0) Gecko/20100101 Firefox/47.0
OS: Windows_NT 6.1 x86-64
Multiprocess Windows: 1/1 (Enabled by user)
Safe Mode: false

Crash Reports for the Last 3 Days

All Crash Reports


Name: DOM Inspector
Version: 2.0.16
Enabled: true

Name: Firefox Hello Beta
Version: 1.1.2
Enabled: true

Name: geckoprofiler
Version: 1.16.14
Enabled: true
ID: jid0-edalmuivkozlouyij0lpdx548bc@jetpack

Name: Mozilla Tree Status
Enabled: true

Name: Pocket
Version: 47.0a1
Enabled: true

Name: Statuser
Version: 0.1.4
Enabled: true
ID: @statuser

Name: tab-crasher
Version: 0.1.1-signed
Enabled: true
ID: jid1-KrxrrWKPOoE4Mw@jetpack

Name: wontfix
Version: 1.0
Enabled: true
ID: jid1-SDCOUnA2RvYHFg@jetpack

Name: 'Sup Son
Version: 0.1.1
Enabled: false
ID: @sup-son

Name: about:addons-memory
Version: 10.1-signed
Enabled: false

Name: Add-on Compatibility Reporter
Enabled: false

Name: australis-bugzilla-widget
Version: 0.1
Enabled: false
ID: jid1-Z6r2SFr66RSx4Q@jetpack

Name: Beyond Australis
Version: 1.4.3
Enabled: false
ID: thefoxonlybetter@quicksaver

Name: Bugzilla Tweaks
Enabled: false
ID: jid0-qBnIpLfDFa4LpdrjhAC6vBqN20Q@jetpack

Name: Buttons Back
Version: 8.1-signed
Enabled: false

Name: Change Max Rows of Autocomplete In URL Bar
Version: 1.4.1-signed
Enabled: false
ID: jid0-PTmUBsaKAokPOYNMcrQbssRkn7Y@jetpack

Name: Check4Change
Version: 1.9.7
Enabled: false

Name: Counter for Mozilla's End of Year Fundraising
Version: 0.0.5
Enabled: false
ID: mofofuraco@archaeopteryx

Name: Cycle Collector Analyzer, about:ccdump
Enabled: false

Name: DevEdition theme enabler
Version: 1.0
Enabled: false

Name: dontbeevil
Enabled: false
ID: jid0-uKv2BxxWlXSDahl79DjVU4yqsvY@jetpack

Name: Evernote Web Clipper
Version: 6.1
Enabled: false
ID: {E0B8C461-F8FB-49b4-8373-FE32E9252800}

Name: feedly
Version: 16.0.528.1-signed
Enabled: false
ID: feedly@devhd

Name: Firefox Interest Dashboard
Enabled: false
ID: firefox.interest.dashboard@up.mozilla

Name: FireGestures
Version: 1.10.5
Enabled: false

Name: Ghostery
Version: 5.4.10
Enabled: false

Name: GitHub Extension Installer
Version: 1.7.0
Enabled: false
ID: {86054B0A-BD85-42F9-8E58-8794EC6F6EA1}

Name: Greasemonkey
Version: 3.6
Enabled: false
ID: {e4a8a97b-f2ed-450b-b12d-ee082ba24781}

Name: Heartbleed Monitor
Enabled: false
ID: jid1-eMhaOaq3SPBFDg@jetpack

Name: Imgur Uploader
Enabled: false

Name: LastPass
Version: 3.2.42
Enabled: false

Name: Lightbeam
Enabled: false
ID: jid1-F9UJ2thwoAm5gQ@jetpack

Name: Media Hint
Enabled: false
ID: mediahint@jetpack

Name: MemChaser
Version: 0.7
Enabled: false

Name: Modify Headers
Enabled: false
ID: {b749fc7c-e949-447f-926c-3f4eed6accfe}

Name: Muditanist
Version: 0.1.1-signed
Enabled: false
ID: jid1-oyNpUQcL3f9kyg@jetpack

Name: New Tab Override (browser.newtab.url replacement)
Version: 2.3.1
Enabled: false

Name: Nicer Bugzilla Comments
Enabled: false
ID: jid0-8OJNdDJ6MBHtfB9FElhQ3wt2FMw@jetpack

Name: Noise Control
Version: 16
Enabled: false
ID: jid1-hUBct1DNfZQIeQ@jetpack

Name: NoScript
Enabled: false
ID: {73a6fe31-595d-460b-a920-fcc0f8843232}

Name: Open in Browser
Version: 1.16
Enabled: false

Name: Profilist
Version: 1.2.1-signed
Enabled: false
ID: Profilist@jetpack

Name: Puzzle Bars
Version: 2.1.11
Enabled: false
ID: thePuzzlePiece@quicksaver

Name: Remote XUL Manager
Version: 1.3.1
Enabled: false

Name: Restartless Restart
Version: 9.1-signed
Enabled: false

Name: Shumway
Version: 0.11.617
Enabled: false

Name: skiptco
Enabled: false

Name: SnoozeTabs
Version: 0.1.1
Enabled: false
ID: jid1-snoozetabs@jetpack

Name: Soundcloud Player
Version: 0.9.1-signed
Enabled: false

Name: SQLite Manager
Enabled: false

Name: Tab Badge
Version: 2
Enabled: false

Name: Tab Data
Enabled: false
ID: jid1-4ogjq7MUzAiCOw@jetpack

Name: Tabsmack
Version: 0.5.0
Enabled: false
ID: jid1-CzCFymQL7Znp9g@jetpack

Name: TabSubmit
Enabled: false
ID: {421e87b4-d3d2-49c8-b08f-b83f4dc88444}

Name: TabSubmit Basic
Enabled: false
ID: jid1-KR7YJG7ASAuPHQ@jetpack

Name: TART - Tab Animation regression Test
Version: 1.0
Enabled: false

Name: Terms of Service; Didn’t Read
Enabled: false
ID: jid0-3GUEt1r69sQNSrca5p8kx9Ezc3U@jetpack

Name: Test Pilot
Enabled: false

Name: test-widget
Version: 0.1
Enabled: false
ID: jid1-ahoQUEjmds0TqQ@jetpack

Name: Textarea Cache
Enabled: false
ID: {578e7caa-210f-4967-a0d3-88fe5b59a39f}

Name: The Addon Bar (restored)
Version: 3.2.9-compat-fixed
Enabled: false
ID: the-addon-bar@GeekInTraining-GiT

Name: The Grim Tab Reaper
Version: 0.2.1-signed
Enabled: false
ID: jid1-VOwFjnJ0krddcw@jetpack

Name: TinEye Reverse Image Search
Version: 1.2.1
Enabled: false

Name: Toggle animated GIFs
Version: 1.3
Enabled: false

Name: Toggle Paint Flashing
Version: initial.rev7.1-signed
Enabled: false
ID: jid0-vUWmQUzNnMcAZ6NPmhAEmMjI66M@jetpack

Name: Toolbar Autohide
Version: 6.7.2
Enabled: false
ID: fullscreentoolbarhover@com.sppad

Name: Translate This!
Version: 3.5.0
Enabled: false
ID: jid0-k75TfRGfOXPHfEZmJ9cKu5eCgLc@jetpack

Name: User Agent Overrider
Version: 0.3.0
Enabled: false

Name: Visual Hashing
Version: 0.3.1-signed
Enabled: false
ID: jid1-NzIEzRc5sYX4Ww@jetpack

Name: Wallflower
Enabled: false
ID: jid1-uB4sJEPvR2m4QQ@jetpack

Name: WCAG Contrast checker
Enabled: false

Name: ZenHub
Version: 2.15.46
Enabled: false


Adapter Description: Intel(R) HD Graphics P3000
Adapter Drivers: igdumd64 igd10umd64 igd10umd64 igdumd32 igd10umd32 igd10umd32
Adapter RAM: Unknown
Asynchronous Pan/Zoom: wheel input enabled; touch input enabled
Device ID: 0x010a
Direct2D Enabled: true
DirectWrite Enabled: true (6.2.9200.17461)
Driver Date: 3-20-2014
Driver Version:
GPU #2 Active: false
GPU Accelerated Windows: 1/1 Direct3D 11 (OMTC)
Subsys ID: 04981028
Supports Hardware H264 Decoding: Yes
Vendor ID: 0x8086
WebGL Renderer: Google Inc. -- ANGLE (Intel(R) HD Graphics P3000 Direct3D11 vs_4_1 ps_4_1)
windowLayerManagerRemote: true
AzureCanvasBackend: direct2d 1.1
AzureContentBackend: direct2d 1.1
AzureFallbackCanvasBackend: cairo
AzureSkiaAccelerated: 0

Important Modified Preferences

accessibility.typeaheadfind.flashBar: 0
browser.cache.disk.capacity: 358400
browser.cache.disk.filesystem_reported: 1
browser.cache.disk.hashstats_reported: 1
browser.cache.disk.smart_size_cached_value: 358400
browser.cache.disk.smart_size.first_run: false
browser.cache.disk.smart_size.use_old_max: false
browser.cache.frecency_experiment: 3 true true
browser.places.smartBookmarksVersion: 7 true
browser.sessionstore.upgradeBackup.latestBuildID: 20160211075650
browser.startup.homepage: about:home
browser.startup.homepage_override.buildID: 20160217030229
browser.startup.homepage_override.mstone: 47.0a1
browser.tabs.remote.autostart: true
browser.tabs.remote.autostart.2: false
browser.tabs.warnOnOpen: false
browser.urlbar.maxRichResults: 50
browser.urlbar.suggest.searches: true
browser.urlbar.userMadeSearchSuggestionsChoice: true
dom.allow_XUL_XBL_for_file: false
dom.apps.reset-permissions: true
dom.disable_open_during_load: false
dom.mozApps.maxLocalId: 1008
dom.mozApps.runUpdate: false
dom.mozApps.used: true
dom.mozContacts.enabled: true
dom.mozTCPSocket.enabled: true
dom.w3c_touch_events.expose: false
extensions.lastAppVersion: 47.0a1
font.internaluseonly.changed: true
gfx.crash-guard.d3d11layers.appVersion: 43.0a1
gfx.crash-guard.d3d11layers.deviceID: 0x010a
gfx.crash-guard.d3d11layers.feature-d2d: true
gfx.crash-guard.d3d11layers.feature-d3d11: true
gfx.crash-guard.glcontext.gfx.driver-init.direct3d11-angle: true
gfx.crash-guard.glcontext.gfx.driver-init.webgl-angle: true
gfx.crash-guard.glcontext.gfx.driver-init.webgl-angle-force-d3d11: false
gfx.crash-guard.glcontext.gfx.driver-init.webgl-angle-force-warp: false
gfx.crash-guard.glcontext.gfx.driver-init.webgl-angle-try-d3d11: true
gfx.crash-guard.status.d3d11layers: 2
gfx.crash-guard.status.d3d9video: 2
gfx.crash-guard.status.glcontext: 2
gfx.direct3d.last_used_feature_level_idx: 0
gfx.driver-init.appVersion: 43.0a1
gfx.driver-init.deviceID: 0x010a
gfx.driver-init.feature-d2d: true
gfx.driver-init.feature-d3d11: true
gfx.driver-init.status: 2
media.gmp-gmpopenh264.abi: x86_64-msvc-x64
media.gmp-gmpopenh264.enabled: true
media.gmp-gmpopenh264.lastUpdate: 1451919922
media.gmp-gmpopenh264.version: 1.5.3
media.gmp-manager.buildID: 20160217030229
media.gmp-manager.lastCheck: 1455739046
media.hardware-video-decoding.failed: false
network.cookie.prefsMigrated: true
network.predictor.cleaned-up: true
places.database.lastMaintenance: 1455299703
places.history.expiration.transient_current_max_pages: 104858
plugin.disable_full_page_plugin_for_types: application/pdf
plugin.importedState: true
plugin.state.flash: 1 0
plugin.state.npdeployjava: 0
plugin.state.npgoogleupdate: 0
plugin.state.nppdf: 0
plugin.state.npspwrap: 0
plugin.state.npwatweb: 0
plugin.state.npwlpg: 0
print.printer_CutePDF_Writer.print_bgcolor: false
print.printer_CutePDF_Writer.print_bgimages: false
print.printer_CutePDF_Writer.print_downloadfonts: false
print.printer_CutePDF_Writer.print_duplex: 6881395
print.printer_CutePDF_Writer.print_edge_bottom: 0
print.printer_CutePDF_Writer.print_edge_left: 0
print.printer_CutePDF_Writer.print_edge_right: 0
print.printer_CutePDF_Writer.print_edge_top: 0
print.printer_CutePDF_Writer.print_evenpages: true
print.printer_CutePDF_Writer.print_footerleft: &PT
print.printer_CutePDF_Writer.print_footerright: &D
print.printer_CutePDF_Writer.print_headerleft: &T
print.printer_CutePDF_Writer.print_headerright: &U
print.printer_CutePDF_Writer.print_in_color: true
print.printer_CutePDF_Writer.print_margin_bottom: 0.5
print.printer_CutePDF_Writer.print_margin_left: 0.5
print.printer_CutePDF_Writer.print_margin_right: 0.5
print.printer_CutePDF_Writer.print_margin_top: 0.945138931274414
print.printer_CutePDF_Writer.print_oddpages: true
print.printer_CutePDF_Writer.print_orientation: 0
print.printer_CutePDF_Writer.print_page_delay: 50
print.printer_CutePDF_Writer.print_paper_data: 1
print.printer_CutePDF_Writer.print_paper_height: 11.00
print.printer_CutePDF_Writer.print_paper_size_type: 0
print.printer_CutePDF_Writer.print_paper_size_unit: 0
print.printer_CutePDF_Writer.print_paper_width: 8.50
print.printer_CutePDF_Writer.print_resolution: 6881398
print.printer_CutePDF_Writer.print_reversed: false
print.printer_CutePDF_Writer.print_scaling: 0.30
print.printer_CutePDF_Writer.print_shrink_to_fit: false
print.printer_CutePDF_Writer.print_to_file: false
print.printer_CutePDF_Writer.print_unwriteable_margin_bottom: 0
print.printer_CutePDF_Writer.print_unwriteable_margin_left: 0
print.printer_CutePDF_Writer.print_unwriteable_margin_right: 0
print.printer_CutePDF_Writer.print_unwriteable_margin_top: 0
print.printer_Gestetner_MP_C2551_PCL_6.print_bgcolor: false
print.printer_Gestetner_MP_C2551_PCL_6.print_bgimages: false
print.printer_Gestetner_MP_C2551_PCL_6.print_downloadfonts: false
print.printer_Gestetner_MP_C2551_PCL_6.print_duplex: 6881395
print.printer_Gestetner_MP_C2551_PCL_6.print_edge_bottom: 0
print.printer_Gestetner_MP_C2551_PCL_6.print_edge_left: 0
print.printer_Gestetner_MP_C2551_PCL_6.print_edge_right: 0
print.printer_Gestetner_MP_C2551_PCL_6.print_edge_top: 0
print.printer_Gestetner_MP_C2551_PCL_6.print_evenpages: true
print.printer_Gestetner_MP_C2551_PCL_6.print_footerleft: &PT
print.printer_Gestetner_MP_C2551_PCL_6.print_footerright: &D
print.printer_Gestetner_MP_C2551_PCL_6.print_headerleft: &T
print.printer_Gestetner_MP_C2551_PCL_6.print_headerright: &U
print.printer_Gestetner_MP_C2551_PCL_6.print_in_color: true
print.printer_Gestetner_MP_C2551_PCL_6.print_margin_bottom: 0.5
print.printer_Gestetner_MP_C2551_PCL_6.print_margin_left: 0.5
print.printer_Gestetner_MP_C2551_PCL_6.print_margin_right: 0.5
print.printer_Gestetner_MP_C2551_PCL_6.print_margin_top: 0.945138931274414
print.printer_Gestetner_MP_C2551_PCL_6.print_oddpages: true
print.printer_Gestetner_MP_C2551_PCL_6.print_orientation: 1
print.printer_Gestetner_MP_C2551_PCL_6.print_page_delay: 50
print.printer_Gestetner_MP_C2551_PCL_6.print_paper_data: 9
print.printer_Gestetner_MP_C2551_PCL_6.print_paper_height: 11.00
print.printer_Gestetner_MP_C2551_PCL_6.print_paper_size_type: 0
print.printer_Gestetner_MP_C2551_PCL_6.print_paper_size_unit: 1
print.printer_Gestetner_MP_C2551_PCL_6.print_paper_width: 8.50
print.printer_Gestetner_MP_C2551_PCL_6.print_resolution: 6881398
print.printer_Gestetner_MP_C2551_PCL_6.print_reversed: false
print.printer_Gestetner_MP_C2551_PCL_6.print_scaling: 1.50
print.printer_Gestetner_MP_C2551_PCL_6.print_shrink_to_fit: true
print.printer_Gestetner_MP_C2551_PCL_6.print_to_file: false
print.printer_Gestetner_MP_C2551_PCL_6.print_unwriteable_margin_bottom: 0
print.printer_Gestetner_MP_C2551_PCL_6.print_unwriteable_margin_left: 0
print.printer_Gestetner_MP_C2551_PCL_6.print_unwriteable_margin_right: 0
print.printer_Gestetner_MP_C2551_PCL_6.print_unwriteable_margin_top: 0
print.printer_TOR5-DrClaw.print_bgcolor: false
print.printer_TOR5-DrClaw.print_bgimages: false
print.printer_TOR5-DrClaw.print_downloadfonts: false
print.printer_TOR5-DrClaw.print_duplex: 6881395
print.printer_TOR5-DrClaw.print_edge_bottom: 0
print.printer_TOR5-DrClaw.print_edge_left: 0
print.printer_TOR5-DrClaw.print_edge_right: 0
print.printer_TOR5-DrClaw.print_edge_top: 0
print.printer_TOR5-DrClaw.print_evenpages: true
print.printer_TOR5-DrClaw.print_footerleft: &PT
print.printer_TOR5-DrClaw.print_footerright: &D
print.printer_TOR5-DrClaw.print_headerleft: &T
print.printer_TOR5-DrClaw.print_headerright: &U
print.printer_TOR5-DrClaw.print_in_color: true
print.printer_TOR5-DrClaw.print_margin_bottom: 0.5
print.printer_TOR5-DrClaw.print_margin_left: 0.5
print.printer_TOR5-DrClaw.print_margin_right: 0.5
print.printer_TOR5-DrClaw.print_margin_top: 0.945138931274414
print.printer_TOR5-DrClaw.print_oddpages: true
print.printer_TOR5-DrClaw.print_orientation: 0
print.printer_TOR5-DrClaw.print_page_delay: 50
print.printer_TOR5-DrClaw.print_paper_data: 9
print.printer_TOR5-DrClaw.print_paper_height: 11.00
print.printer_TOR5-DrClaw.print_paper_size_type: 0
print.printer_TOR5-DrClaw.print_paper_size_unit: 1
print.printer_TOR5-DrClaw.print_paper_width: 8.50
print.printer_TOR5-DrClaw.print_resolution: 6881398
print.printer_TOR5-DrClaw.print_reversed: false
print.printer_TOR5-DrClaw.print_scaling: 0.30
print.printer_TOR5-DrClaw.print_shrink_to_fit: false
print.printer_TOR5-DrClaw.print_to_file: false
print.printer_TOR5-DrClaw.print_unwriteable_margin_bottom: 0
print.printer_TOR5-DrClaw.print_unwriteable_margin_left: 0
print.printer_TOR5-DrClaw.print_unwriteable_margin_right: 0
print.printer_TOR5-DrClaw.print_unwriteable_margin_top: 0
privacy.clearOnShutdown.cookies: false
privacy.clearOnShutdown.offlineApps: true
privacy.donottrackheader.enabled: true
privacy.sanitize.migrateClearSavedPwdsOnExit: true
privacy.sanitize.migrateFx3Prefs: true
privacy.trackingprotection.enabled: true
privacy.trackingprotection.introCount: 20
security.disable_button.openCertManager: false
security.sandbox.content.tempDirSuffix: {10aa2415-98ed-4fec-8fdf-78ad1b5c87e5}
services.sync.declinedEngines: passwords
services.sync.engine.prefs.modified: false
services.sync.lastPing: 1455644498
services.sync.lastSync: Tue Feb 16 2016 12:56:14 GMT-0500 (Eastern Standard Time)
services.sync.numClients: 3
storage.vacuum.last.index: 1
storage.vacuum.last.places.sqlite: 1454521987

Important Locked Preferences


Incremental GC: true


Activated: false
Prevent Accessibility: 0

Library Versions

Expected minimum version: 4.12 Beta
Version in use: 4.12 Beta

Expected minimum version: 3.23 Basic ECC Beta
Version in use: 3.23 Basic ECC Beta

Expected minimum version: 3.23 Basic ECC Beta
Version in use: 3.23 Basic ECC Beta

Expected minimum version: 3.23 Basic ECC Beta
Version in use: 3.23 Basic ECC Beta

Expected minimum version: 3.23 Beta
Version in use: 3.23 Beta

Experimental Features

Name: Invisible test of the experiment branching system.
Description: An experiment using branches just to test whether branches get saved correctly.
Active: false
End Date: 1409600592348
Branch: 4

Name: tile switcher
Description: An add-on which switches the location of NewTab tiles.
Active: false
End Date: 1399494158646
Branch: null
Severity: normal → major
Hey Mason,

Milan said you might be interested in this. Also cc'ing gw280 who was interested.

Flags: needinfo?(mchang)
(In reply to Mike Conley (:mconley) - Needinfo me! from comment #2)
> Hey Mason,
> Milan said you might be interested in this. Also cc'ing gw280 who was
> interested.
> -Mike

That's an odd bug. Did you update drivers recently? Does it still happen on a clean profile? How often does it happen?
Flags: needinfo?(mchang) → needinfo?(mconley)
(In reply to Mason Chang [:mchang] from comment #3)
> (In reply to Mike Conley (:mconley) - Needinfo me! from comment #2)
> > Hey Mason,
> > 
> > Milan said you might be interested in this. Also cc'ing gw280 who was
> > interested.
> > 
> > -Mike

Hey mchang, sorry for the delay. I was away from my machine since last Friday.

> That's an odd bug. Did you update drivers recently?

I had not when I originally filed this bug, but you asking that prompted me to update my drivers since it turned out I was a few versions behind. So I hit them before with the old drivers, and I hit them again today with the newer ones.

> Does it still happen on
> a clean profile?

Unsure. I've certainly not experienced it with anything except my default profile here.

> How often does it happen?

Pretty frequently. It's hit me 3 times within the past 3 hours today.
Flags: needinfo?(mconley)
This is odd. Does it also happen with e10s disabled?

Can you also try these debug builds? It has some logging around vsync. (builds should be ready in 2-3 hours from this posting).

Flags: needinfo?(mconley)
I ran with a new profile today, and didn't run into it. I'll try your build with my original profile tomorrow. Thanks!
(In reply to Mike Conley (:mconley) - Needinfo me! from comment #6)
> I ran with a new profile today, and didn't run into it. I'll try your build
> with my original profile tomorrow. Thanks!

Great, if you aren't running into it, can you please attach any logs you have here please? I kind of want to see which error you're hitting and we're correcting for. Thanks!
I ran with the debug build on my default profile all day and didn't hit the snag. When I started up a normal Nightly today with that profile, I locked immediately.

So I restarted the debug build and captured the logging output for a bit of running time. Is this at all useful?
Flags: needinfo?(mconley)
Attached file
Whoa! When I was about to attach my zip of the log of me _not_ logging, I locked as soon as I opened the File Attachment window. Luckily, I captured that log, which I'm attaching now.
Flags: needinfo?(mchang)
Attached file
Here's the log of me not locking up.
I think either DWMFlush or DWMGetCompositionTimingInfo failed here. The logs didn't actually have any data in them, which is odd, but it fixed the issue for Mike.

@Mike - Can you also please try this build and verify it fixes the issue for you - - Also, if you happen to run the debug log and see lots of spew, please paste the spew here.
Flags: needinfo?(mchang) → needinfo?(mconley)
Attachment #8723694 - Flags: review?(bugmail.mozilla)
Assignee: nobody → mchang
Comment on attachment 8723694 [details] [diff] [review]
Check that DWM Flush Executes Correctly

Review of attachment 8723694 [details] [diff] [review]:

r=me with comments addressed

::: gfx/thebes/gfxWindowsPlatform.cpp
@@ +2799,2 @@
>            if (SUCCEEDED(hr)) {
> +            hr = WinUtils::dwmGetCompositionTimingInfoPtr(0, &vblankTime);

I'd prefer structuring this with less nesting so it's a bit easier to read:

if (!SUCCEEDED(hr)) {
  // ...

hr = WinUtils::dwmGetCompositionTimingInfoPtr(...);
if (!SUCCEEDED(hr)) {
  // ...

vsync = ...;

@@ +2808,5 @@
> +            // We don't actually know how long we had to wait on DWMFlush
> +            // Instead of trying to calculate how long DwmFlush actually took,
> +            // fallback to software vsync for this one interval and hope
> +            // the DWM comes back up on the next interval.
> +            NS_WARNING("DWM Flush failed. Scheduling a software vsync\n");

drop this warning, it has the potential to flood logs if for some reason we hit this every time. Either that or guard it with something so that it only happens once.
Attachment #8723694 - Flags: review?(bugmail.mozilla) → review+
I ran your build today, and it ran really well, up until about a minute ago, when it hung. I didn't have the wit to grab the symbols, so I wasn't able to be certain that it was the same hang.

So, observation:

1) Your patch either fixed it, or
2) Your patch made it a lot more rare

I'll start running with the debug version now.
Carrying r+, updated with :kats feedback. Successful try:
Attachment #8723694 - Attachment is obsolete: true
Attachment #8724680 - Flags: review+
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla47
I think the less frequent hang I'm hitting now is unrelated - filed bug 1252587.
Flags: needinfo?(mconley)
Comment on attachment 8724680 [details] [diff] [review]
Check that DWMFlush executes correctly

Approval Request Comment
[Feature/regressing bug #]: Silk
[User impact if declined]: Sometimes random long hangs on Windows.
[Describe test coverage new/current, TreeHerder]: Manual, treeherder
[Risks and why]: Low - This fallsback to software if windows vsync sometimes intermittently fails.
[String/UUID change made/needed]: None
Attachment #8724680 - Flags: approval-mozilla-aurora?
Comment on attachment 8724680 [details] [diff] [review]
Check that DWMFlush executes correctly

Fix for a Windows hang, tested manually, let's try this on 46 too.
Attachment #8724680 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
You need to log in before you can comment on or make changes to this bug.