1249046 - Stored push messages don't trigger pop-up notification on Nightly

Status: VERIFIED FIXED

(Core :: DOM: Push Subscriptions, defect)

Description

[Richard Pappalardo [:rpapa][:rpappalardo]]

SUMMARY
In Nightly 44.0.2, delayed (stored) push notification don't trigger pop-up notification (though push notification appear to be delivered in web console).


STR
purpose: verify that a request is stored on autopush for delayed delivery

setup:
start browser with new profile
open: about:config
set: dom.push.loglevel=debug (instead of 'off')
open: Tools > WebDeveloper > BrowserConsole

open: https://people.mozilla.org/~ewong2/push-notification-test/
set: TTL = 120
set: Repeat = 2
set: Delay (seconds): 15
choose: "service-worker.js"
click: "register Service Worker"
click: "subscribe to push"
observe push registration in console
click: "Always Receive Notifications" (in pop-up window)

 
click: "XHR to webpush app-server
wait for pop notification, then immediately close browser
wait 30 seconds
re-open browser


SHOULD SEE:
delayed message delivery on browser restart via pop-up notification.


ACTUAL
message appears to be delivered in console, but pop-up notification never triggers

Comment 1

[Lina Butler [:lina]]

This looks like a recent regression. I haven't bisected it yet.

Comment 2

[Andrew Overholt [:overholt]]

Did this break between 44{,.0.1} and 44.0.2?

Kit, feel free to give this to someone else if you don't have time for it.

Comment 3

[Richard Pappalardo [:rpapa][:rpappalardo]]

(In reply to Andrew Overholt [:overholt] from comment #2)
> Did this break between 44{,.0.1} and 44.0.2?
> 
> Kit, feel free to give this to someone else if you don't have time for it.

I've only been testing storage since last autopush release but neglected to make a note at that time if I tested on Nightly or a different version.

Comment 4

[Richard Pappalardo [:rpapa][:rpappalardo]]

Sorry, correction: I'm seeing this on Mac Nightly 47.0a1 not 44.0.2

Comment 5

[Richard Pappalardo [:rpapa][:rpappalardo]]

did some further testing with :edwong.  It appears service workers is getting unregistered on browser restart (Nightly).

Comment 6

[Edwin Wong [:edwong]]

:overholt - can someone investigate?  The steps are:
1. go here with nightly: https://people.mozilla.org/~ewong2/push-notification-test/
2. click 'register'
3. click 'subscribe'
4. goto about:debugging to confirm SW exists
5. restart browser
6. goto about:debugging

actual: SW doesn't display in about: debugging

Comment 7

[Andrew Overholt [:overholt]]

Is the SW displaying in about:debugging related? I didn't think we had about:debugging working with e10s yet.

Comment 8

[Edwin Wong [:edwong]]

I'm just using about:debugging to confirm the registration of the SW. Upon restart - it's no longer registered.

Comment 9

[Andrew Overholt [:overholt]]

(In reply to Edwin Wong [:edwong] from comment #6)
> :overholt - can someone investigate?  The steps are:
> 1. go here with nightly:
> https://people.mozilla.org/~ewong2/push-notification-test/
> 2. click 'register'
> 3. click 'subscribe'
> 4. goto about:debugging to confirm SW exists
> 5. restart browser
> 6. goto about:debugging
> 
> actual: SW doesn't display in about: debugging

We're trying to deprecate it but the registered SW does continue to show up in about:serviceworkers.

Comment 10

[Andrew Overholt [:overholt]]

Ben/baku, any thoughts?

Comment 11

[Ben Kelly [:bkelly, not reviewing]]

I believe this is a regression from bug 1246319.

Comment 12

[Ben Kelly [:bkelly, not reviewing]]

Wait.  The regression I am seeing about service worker missing on restart is only in 46+.  I will file a new bug for that.  The original comment 0 is talking about FF44 issue.

Comment 13

[Lina Butler [:lina]]

I think this is the regression. :rpapa clarified in comment 4 that he's seeing this on FF 47, not 44.

Comment 14

[Ben Kelly [:bkelly, not reviewing]]

I just pushed a fix in bug 1246319 comment 32.  Does that address the symptoms you are seeing?

Comment 15

[Richard Pappalardo [:rpapa][:rpappalardo]]

(In reply to Ben Kelly [PTO, back Feb 29][:bkelly] from comment #14)
> I just pushed a fix in bug 1246319 comment 32.  Does that address the
> symptoms you are seeing?

Yes, thanks Ben.  push notifications are being stored now on Nightly.
verified on Win10 & OSX (el capitan)

Comment 16

[Richard Pappalardo [:rpapa][:rpappalardo]]

SoftVision has also verified on 6 platforms with Multi process enabled and disabled.
Thanks guys!