Closed Bug 1249049 Opened 8 years ago Closed 8 years ago

Debugging worker throws gDevTools is undefined at devtools/content/debugger/debugger-controller.js:512:7

Categories

(DevTools :: Debugger, defect)

Product:
DevTools
Component:
Debugger
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox47 fixed)

Status:
RESOLVED FIXED
Milestone:
Firefox 47
Tracking Flags:
Tracking Status
firefox47 --- fixed

People

(Reporter: ochameau, Assigned: ochameau)

References

Details

Attachments

(1 file, 1 obsolete file)

patch v2
2.30 KB, patch
ejpbruel
: review+
Details | Diff | Splinter Review 
Most likely introduced by bug 1245462. gDevTools was magically inserted into all scopes via a Cu.import(gDevTools.jsm). Without a second argument, Cu.import exports symbols to the global scope, which happens to be merged with Loader.jsm.

We simply need to explicitely load this symbol.
Attached patch patch v1 (obsolete) — — Splinter Review 
While I'm at hit, fixing the spaces of a similar import in perf panel.
Attachment #8720370 - Flags: review?(ejpbruel)
Attached patch patch v2 — — Splinter Review 
Sorry for the spam. This patch should apply cleanly on fx-team.
Attachment #8720371 - Flags: review?(ejpbruel)
Attachment #8720370 - Attachment is obsolete: true
Attachment #8720370 - Flags: review?(ejpbruel)
Attachment #8720371 - Flags: review?(ejpbruel) → review+
https://hg.mozilla.org/integration/fx-team/rev/a3458328b296fd1361c817b8c9e1d1e5bfdd64bb
Bug 1249049 - Fix gDevTools is undefined exception when debugging workers. r=ejpbruel
https://hg.mozilla.org/mozilla-central/rev/a3458328b296
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox47: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 47
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: