main-ping fields with undocumented structure

RESOLVED FIXED in Firefox 47

Status

()

Toolkit
Telemetry
P1
normal
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: Sam Penrose, Assigned: Dexter)

Tracking

unspecified
mozilla47
Points:
2

Firefox Tracking Flags

(firefox47 fixed)

Details

(Whiteboard: [measurement:client])

Attachments

(1 attachment)

(Reporter)

Description

2 years ago
+++ This bug was initially created as a clone of Bug #1243893 +++

The following fields could use documentation of their structure:

- payload/addonDetails
- payload/lateWrites
- payload/simpleMeasurements
- payload/slowSQL and slowSQLStartup
- payload/UIMeasurements

Comment 1

2 years ago
I can help a bit with some background on two of these:

slowSQL is a keyed histogram of SQL statements that are "slow". slowSQLStartup is the same thing, but only including statements that run during application startup.
(Reporter)

Comment 2

2 years ago
(In reply to Chris H-C :chutten from comment #1)
> I can help a bit with some background on two of these:
> 
> slowSQL is a keyed histogram of SQL statements that are "slow".
> slowSQLStartup is the same thing, but only including statements that run
> during application startup.

Thanks! I have reverse-engineered a bit of it, but I'd like more definitive type information. Alessio, can you put this on your list?
Flags: needinfo?(alessio.placitelli)
(Assignee)

Comment 3

2 years ago
Sure, I'll document the structure of those fields. It looks like the high level documentation for most of them is already there (slowSQL/slowSQLStartup as well). Leaving the ni? around as a reminder!
(Assignee)

Updated

2 years ago
Assignee: nobody → alessio.placitelli
Flags: needinfo?(alessio.placitelli)
(Assignee)

Comment 4

2 years ago
Created attachment 8724726 [details] [diff] [review]
bug1249073.patch

This patch does not add any additional information to the simpleMeasurement's docs, as I'm not sure how to improve that.

It also fixes a typo in the webRTC docs ("releated" -> "related").
Attachment #8724726 - Flags: review?(gfritzsche)
Attachment #8724726 - Flags: review?(gfritzsche) → review+
(Assignee)

Comment 5

2 years ago
Sam, do you have any suggestion about how to improve payload/simpleMeasurements? Anything that could be added on the current readthedocs - https://gecko.readthedocs.org/en/latest/toolkit/components/telemetry/telemetry/main-ping.html#simplemeasurements ?
Flags: needinfo?(spenrose)
(Reporter)

Comment 6

2 years ago
I simply missed that section; apologies for the confusion. simpleMeasurements is well documented.

(In reply to Alessio Placitelli [:Dexter] from comment #5)
> Sam, do you have any suggestion about how to improve
> payload/simpleMeasurements? Anything that could be added on the current
> readthedocs -
> https://gecko.readthedocs.org/en/latest/toolkit/components/telemetry/
> telemetry/main-ping.html#simplemeasurements ?
Flags: needinfo?(spenrose)
(Assignee)

Comment 7

2 years ago
No problem Sam, thanks for clarifying!

No try push needed for the check-in, as this only updates the docs.
Status: NEW → ASSIGNED
Keywords: checkin-needed

Comment 9

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/04634ec900b2
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
status-firefox47: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla47
You need to log in before you can comment on or make changes to this bug.