1249096 - Use a more forgiving URL parser when getting the fallback favicon

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Favicon Handling, defect)

Description

[Mark Finkle (:mfinkle) (use needinfo?)]

We try to use Java.net.URI to parse strings into URI pieces. This is certainly preferred over Java.net.URL which tries to make a network connection.

There are times where Java.net.URI is too strict. Browsers tend to be more forgiving and we end up losing data when trying to use Java.net.URI on a URL string loaded into the Browser.

An example is in favicons [1], where we try to create a "root" /favicon fallback based on a loaded page URL. If the URL is "http://example.com#foo#bar", then Java.net.URI will fail. This URL loads into Firefox just fine and we lose fetching the favicon.

Could we try using Android.net.Uri [2] which is much more forgiving? I also found a class in OkHTTP [3]

[1] http://mxr.mozilla.org/mozilla-central/source/mobile/android/base/java/org/mozilla/gecko/favicons/Favicons.java#523
[2] http://developer.android.com/reference/android/net/Uri.html
[3] https://corner.squareup.com/2015/05/okhttp-2-4.html

Comment 1

[Mark Finkle (:mfinkle) (use needinfo?)]

Attachment: lenient-url-parser v0.1

Switch to Android.net.Uri

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

I re-scoped this bug to the specific situation we found. We should file new bugs for other situations.

Comment 3

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/d6c06db9e3d4

Comment 4

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/d6c06db9e3d4