Closed
Bug 1249134
Opened 9 years ago
Closed 9 years ago
Remove support for "-webkit-appearance" for now, since in practice it works differently from "-moz-appearance"
Categories
(Core :: CSS Parsing and Computation, defect)
Core
CSS Parsing and Computation
Tracking
()
RESOLVED
FIXED
mozilla47
Tracking | Status | |
---|---|---|
firefox47 | --- | fixed |
People
(Reporter: dholbert, Assigned: dholbert)
References
Details
Attachments
(1 file)
2.30 KB,
patch
|
heycam
:
review+
|
Details | Diff | Splinter Review |
As noted in bug 1236506 and bug 605985, "-moz-appearance:none" doesn't really work the same way "-webkit-appearance:none" does (at least, not for checkboxes & radio buttons).
So, for sites that are conscientious and use feature-detection to sniff for "-webkit-appearance" support (and provide fallback when it's not), our current aliasing behavior (on Nightly) moves us from working fallback code to not-working -webkit-appearance dependent code. (where "not working" means "checkbox maybe still shows up but it looks out of place because it's not themed like the rest of the site")
This is a usability regression. See screenshots on bug 1236506 for an example of this.
We should probably hold off on shipping "-webkit-appearance" as an alias, at least until we've got a better plan for bug 605985.
Assignee | ||
Updated•9 years ago
|
Summary: Remove support for "-webkit-appearance" for now, since in practice it's not a strict alias for "-moz-appearance" → Remove support for "-webkit-appearance" for now, since in practice works differently from "-moz-appearance"
Assignee | ||
Updated•9 years ago
|
Assignee | ||
Comment 1•9 years ago
|
||
Attachment #8720508 -
Flags: review?(cam)
Assignee | ||
Updated•9 years ago
|
Assignee: nobody → dholbert
Status: NEW → ASSIGNED
Assignee | ||
Updated•9 years ago
|
Summary: Remove support for "-webkit-appearance" for now, since in practice works differently from "-moz-appearance" → Remove support for "-webkit-appearance" for now, since in practice it works differently from "-moz-appearance"
Assignee | ||
Comment 2•9 years ago
|
||
I believe this particular alias wasn't actually buying us too much in terms of site-fixing, which is why I'm not too concerned with removing it.
I think Mike is on board with removing it, too, per bug 605985 comment 42 ("We should probably consider removing the -webkit-appearance alias until we understand all the issues (and ideally match on behavior).")
Updated•9 years ago
|
Attachment #8720508 -
Flags: review?(cam) → review+
Assignee | ||
Comment 3•9 years ago
|
||
Thanks! Sanity-check Try run: https://treeherder.mozilla.org/#/jobs?repo=try&revision=418464266496
Comment 4•9 years ago
|
||
Yep, I think the differences between -moz- and -webkit- are too big for an alias to get us much. Expect bugs to follow once we have a better understanding of how people are using this in the wild (akin to Bug 605985).
Comment 6•9 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla47
Comment 8•8 years ago
|
||
Is there already a bug for reimplementing -webkit-appearance once bug 605985 is fixed?
Sebastian
Flags: needinfo?(dholbert)
Assignee | ||
Comment 9•8 years ago
|
||
Not that I'm aware of. I filed bug 1302104 on that.
Flags: needinfo?(dholbert)
You need to log in
before you can comment on or make changes to this bug.
Description
•