Closed Bug 1249252 Opened 7 years ago Closed 7 years ago

[SharedStubs] performance regressions by using getprop shared stubs

Categories

(Core :: JavaScript Engine: JIT, defect)

Product:
Core
Component:
JavaScript Engine: JIT
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla47
Tracking Flags:
Tracking Status
firefox47 --- fixed

People

(Reporter: h4writer, Assigned: h4writer)

References

Details

Attachments

(1 file)

bug1249252-getprop-regressions
3.53 KB, patch
jandem
: review+
Details | Diff | Splinter Review 
      No description provided.
Blocks: 1214508
Blocks: 1241087
We add a typebarrier when doing the vm call, but not when we do the shared stub case. Adding it, brought crypto back to performance before enabling shared stubs.
Assignee: nobody → hv1989
Attachment #8720759 - Flags: review?(jdemooij)
Attachment #8720759 - Flags: review?(jdemooij) → review+
https://hg.mozilla.org/mozilla-central/rev/3f395a031f6a
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox47: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla47
You need to log in before you can comment on or make changes to this bug.