[layout](uk) Remove key by moving it to alternative character

RESOLVED FIXED

Status

Firefox OS
Gaia::Keyboard
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: Artem Polivanchuk, Assigned: Artem Polivanchuk)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

2 years ago
Current Ukrainian keyboard layout should be modified by removing key "ї".
This key should be available as alternative character for key "і", as it's implemented on other keyboard types.
Created attachment 8721617 [details] [review]
[gaia] stenox:master > mozilla-b2g:master
(Assignee)

Updated

2 years ago
Attachment #8721617 - Flags: review?(timdream)
Comment on attachment 8721617 [details] [review]
[gaia] stenox:master > mozilla-b2g:master

The code looks good because I did not try to visually inspect the built layout.

I've left a small question here:
https://github.com/mozilla-b2g/gaia/pull/34075/files#r53581531

If that's not an issue I will merge it. Thanks for helping!
Flags: needinfo?(a.polivanchuk)
Attachment #8721617 - Flags: review?(timdream) → review+
(Assignee)

Comment 3

2 years ago
Yes, you're right. I've already changed the value and updated PR.
Please, review.
Thanks!
Flags: needinfo?(a.polivanchuk)
master: https://github.com/mozilla-b2g/gaia/commit/b352ccbe592fb25b2c4c49941e4a167c3f0a7eaa
Status: NEW → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.