1249275 - Compilation is broken on mac if sandbox is disabled

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect)

Description

[Jean-Yves Avenard [:jya]]

With options: 
ac_add_options --disable-sandbox
ac_add_options --disable-content-sandbox


17:16.45 In file included from /Users/jyavenard/Work/Mozilla/obj-ff-dbg/dom/media/gmp/Unified_cpp_dom_media_gmp0.cpp:29:
17:16.47 /Users/jyavenard/Work/Mozilla/mozilla-central/dom/media/gmp/GMPChild.cpp:354:8: error: no matching function for call to 'GetPluginFile'
17:16.47   if (!GetPluginFile(mPluginPath, libFile)) {
17:16.47        ^~~~~~~~~~~~~
17:16.47 /Users/jyavenard/Work/Mozilla/mozilla-central/dom/media/gmp/GMPChild.cpp:110:1: note: candidate function not viable: requires 3 arguments, but 2 were provided
17:16.47 GetPluginFile(const nsAString& aPluginPath,
17:16.47 ^
17:25.63 MediaStreamList.o
17:26.92 1 error generated.
17:26.96 

regressions appear to have been introduced by changes bug 1246835

Comment 1

[Jean-Yves Avenard [:jya]]

Attachment: MozReview Request: Bug 1249275: Fix mac compilation when sandbox is disabled. r?gerald

Review commit: https://reviewboard.mozilla.org/r/35471/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/35471/

Comment 2

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Comment on attachment 8720787 [details]
MozReview Request: Bug 1249275: Fix mac compilation when sandbox is disabled. r?gerald

https://reviewboard.mozilla.org/r/35471/#review32185

Good catch, thank you.

Comment 3

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/4cba1f83f797

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/4cba1f83f797