bugzilla.mozilla.org has resumed normal operation. Attachments prior to 2014 will be unavailable for a few days. This is tracked in Bug 1475801.
Please report any other irregularities here.

Compilation is broken on mac if sandbox is disabled

RESOLVED FIXED in Firefox 47

Status

()

Core
Audio/Video: Playback
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: jya, Assigned: jya)

Tracking

({regression})

Trunk
mozilla47
regression
Points:
---

Firefox Tracking Flags

(firefox47 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Assignee)

Description

2 years ago
With options: 
ac_add_options --disable-sandbox
ac_add_options --disable-content-sandbox


17:16.45 In file included from /Users/jyavenard/Work/Mozilla/obj-ff-dbg/dom/media/gmp/Unified_cpp_dom_media_gmp0.cpp:29:
17:16.47 /Users/jyavenard/Work/Mozilla/mozilla-central/dom/media/gmp/GMPChild.cpp:354:8: error: no matching function for call to 'GetPluginFile'
17:16.47   if (!GetPluginFile(mPluginPath, libFile)) {
17:16.47        ^~~~~~~~~~~~~
17:16.47 /Users/jyavenard/Work/Mozilla/mozilla-central/dom/media/gmp/GMPChild.cpp:110:1: note: candidate function not viable: requires 3 arguments, but 2 were provided
17:16.47 GetPluginFile(const nsAString& aPluginPath,
17:16.47 ^
17:25.63 MediaStreamList.o
17:26.92 1 error generated.
17:26.96 

regressions appear to have been introduced by changes bug 1246835
(Assignee)

Updated

2 years ago
Flags: needinfo?(gsquelart)
Flags: needinfo?(cpearce)
(Assignee)

Comment 1

2 years ago
Created attachment 8720787 [details]
MozReview Request: Bug 1249275: Fix mac compilation when sandbox is disabled. r?gerald

Review commit: https://reviewboard.mozilla.org/r/35471/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/35471/
Attachment #8720787 - Flags: review?(gsquelart)
(Assignee)

Updated

2 years ago
Flags: needinfo?(gsquelart)
Flags: needinfo?(cpearce)
(Assignee)

Updated

2 years ago
Assignee: nobody → jyavenard
Comment on attachment 8720787 [details]
MozReview Request: Bug 1249275: Fix mac compilation when sandbox is disabled. r?gerald

https://reviewboard.mozilla.org/r/35471/#review32185

Good catch, thank you.
Attachment #8720787 - Flags: review?(gsquelart) → review+

Comment 4

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/4cba1f83f797
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox47: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla47
You need to log in before you can comment on or make changes to this bug.