Closed
Bug 1249297
Opened 7 years ago
Closed 7 years ago
Remove "double-click to open comment" feature
Categories
(MozReview Graveyard :: General, defect)
MozReview Graveyard
General
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: mconley, Unassigned)
References
()
Details
Bug 1246769 made this optional, and on by default. karlt wrote in bug 1246769 comment 7: I wonder whether this should default to off. I get the feeling more people now are just quoting one line in review comments instead of the code that they are commenting on. Might want mcote or other MozReview core folk to weigh in here, but it's a pretty simple flip if we decide to change it.
Reporter | ||
Comment 1•7 years ago
|
||
Based on bug 1246769 comment 10, re-purposing this bug to remove the double-click to add a comment feature altogether.
Summary: Make "double-click to open comment" off by default → Remove "double-click to open comment" feature
Reporter | ||
Comment 2•7 years ago
|
||
Cc'ing :ted who originally filed bug 1101601 just so he knows what's up.
See Also: → 1101601
Comment 3•7 years ago
|
||
:( I use this, and would have preferred keeping it. I would have been fine with it being off by default.
Reporter | ||
Comment 4•7 years ago
|
||
Would we be okay for keeping it preffed off by default, but available for the people who want to use it, like botond? Alternatively, a quick and easy WebExtension could be built with this capability.
Flags: needinfo?(mcote)
Assignee | ||
Updated•7 years ago
|
Product: Developer Services → MozReview
Reporter | ||
Comment 6•7 years ago
|
||
Talked about this in #mozreview with smacleod. I'll build a quick-and-dirty WebExtension for the folks who want the double-click feature. Backed out the feature here: https://hg.mozilla.org/hgcustom/version-control-tools/rev/144f62196085
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Reporter | ||
Updated•7 years ago
|
Flags: needinfo?(mcote)
Reporter | ||
Comment 7•7 years ago
|
||
This feature has been moved into a browser extension instead: https://addons.mozilla.org/en-US/firefox/addon/rb-doubleclick/
Reporter | ||
Comment 8•7 years ago
|
||
This has been deployed to production.
You need to log in
before you can comment on or make changes to this bug.
Description
•