1249297 - Remove "double-click to open comment" feature

Status: RESOLVED FIXED

(MozReview Graveyard :: General, defect)

Description

[Mike Conley (:mconley) (:⚙️)]

Bug 1246769 made this optional, and on by default.

karlt wrote in bug 1246769 comment 7:

I wonder whether this should default to off.
I get the feeling more people now are just quoting one line in review comments instead of the code that they are commenting on.

Might want mcote or other MozReview core folk to weigh in here, but it's a pretty simple flip if we decide to change it.

Comment 1

[Mike Conley (:mconley) (:⚙️)]

Based on bug 1246769 comment 10, re-purposing this bug to remove the double-click to add a comment feature altogether.

Comment 2

[Mike Conley (:mconley) (:⚙️)]

Cc'ing :ted who originally filed bug 1101601 just so he knows what's up.

Comment 3

[Botond Ballo [:botond]]

:( I use this, and would have preferred keeping it. I would have been fine with it being off by default.

Comment 4

[Mike Conley (:mconley) (:⚙️)]

Would we be okay for keeping it preffed off by default, but available for the people who want to use it, like botond?

Alternatively, a quick and easy WebExtension could be built with this capability.

Comment 6

[Mike Conley (:mconley) (:⚙️)]

Talked about this in #mozreview with smacleod. I'll build a quick-and-dirty WebExtension for the folks who want the double-click feature.

Backed out the feature here:

https://hg.mozilla.org/hgcustom/version-control-tools/rev/144f62196085

Comment 7

[Mike Conley (:mconley) (:⚙️)]

This feature has been moved into a browser extension instead: https://addons.mozilla.org/en-US/firefox/addon/rb-doubleclick/

Comment 8

[Mike Conley (:mconley) (:⚙️)]

This has been deployed to production.