1249298 - Visiting about:cache creates old cache tree

Status: RESOLVED WONTFIX

(Core :: Networking: Cache, defect)

Description

[Michal Novotny [:michal]]

#0  0xffffffff in nsDiskCacheMap::Open(nsIFile*, nsDiskCache::CorruptCacheInfo*, bool) (this=0xde1485f8, cacheDirectory=0xd0fb6180, corruptInfo=0xffb899ec, reportCacheCleanTelemetryData=false)
    at /opt/moz/hg-inbound/netwerk/cache/nsDiskCacheMap.cpp:40
#1  0xffffffff in nsDiskCacheDevice::OpenDiskCache() (this=0xde1485c0)
    at /opt/moz/hg-inbound/netwerk/cache/nsDiskCacheDevice.cpp:998
#2  0xffffffff in nsDiskCacheDevice::Init() (this=0xde1485c0)
    at /opt/moz/hg-inbound/netwerk/cache/nsDiskCacheDevice.cpp:389
#3  0xffffffff in nsCacheService::CreateDiskDevice() (this=0xd4d69000)
    at /opt/moz/hg-inbound/netwerk/cache/nsCacheService.cpp:1599
#4  0xffffffff in nsCacheService::VisitEntriesInternal(nsICacheVisitor*) (this=0xd4d69000, visitor=0xcff90700)
    at /opt/moz/hg-inbound/netwerk/cache/nsCacheService.cpp:1482
#5  0xffffffff in mozilla::net::AppCacheStorage::AsyncVisitStorage(nsICacheStorageVisitor*, bool) (this=
    0xcff906a0, aVisitor=0xd72e9c94, aVisitEntries=false) at /opt/moz/hg-inbound/netwerk/cache2/AppCacheStorage.cpp:162
#6  0xffffffff in nsAboutCache::VisitStorage(nsACString_internal const&) (this=0xd72e9c90, storageName=...)
    at /opt/moz/hg-inbound/netwerk/protocol/about/nsAboutCache.cpp:224
#7  0xffffffff in nsAboutCache::FireVisitStorage() (this=0xd72e9c90)
    at /opt/moz/hg-inbound/netwerk/protocol/about/nsAboutCache.cpp:192

Comment 1

[Honza Bambas (:mayhemer)]

Not worth fixing IMO, and probably also unfixable easily.  After we remove the old cache code, we will left the old data removal code in for few releases.  That will remove any remnants.

Comment 2

[Michal Novotny [:michal]]

Do we have any estimate when the old cache will be removed? Old cache tree contains also block files and they are preallocated, so the old cache occupies 13MB even if it's unused. If we're not going to remove the old cache soon, we should at least disable preallocating the block files.

Comment 3

[Honza Bambas (:mayhemer)]

We are still deleting old cache data on every start.  So I don't think we need to do anything here.