Desktop FTU/Slideshow needs unit test coverage

RESOLVED FIXED

Status

Hello (Loop)
Client
P1
normal
Rank:
12
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: standard8, Assigned: Vidhuran Harichandra Babu)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [btpp-fix-now])

Attachments

(1 attachment)

(Reporter)

Description

2 years ago
The FTU slideshow landed without any tests. We need to add some tests to cover it.

I would propose some unit tests to cover the slideshow.js (not the vendor file in detail necessarily), and a mochitest to check the general functionality.
Blocks: 1248604
Rank: 15
Priority: -- → P1
Whiteboard: [triage] → [btpp-fix-now]
(Reporter)

Updated

2 years ago
Rank: 15 → 12
(Reporter)

Comment 1

2 years ago
Note: this is for unit tests to run in karma / with the index.html files. Don't forget to update the test/index.html to reference the additional index.html that'll be required.
Summary: Desktop FTU/Slideshow needs test coverage → Desktop FTU/Slideshow needs unit test coverage
(Reporter)

Updated

2 years ago
Assignee: nobody → vidhuran2012

Comment 2

2 years ago
Created attachment 8723529 [details] [review]
[loop] Vidhuran:bug1249311-ftu-unittests > mozilla:master
(Assignee)

Updated

2 years ago
Attachment #8723529 - Flags: review?(standard8)
(Reporter)

Comment 3

2 years ago
Note: comment 0 mentioned about mochitest - that's going to happen in bug 1250107.
(Reporter)

Comment 4

2 years ago
Comment on attachment 8723529 [details] [review]
[loop] Vidhuran:bug1249311-ftu-unittests > mozilla:master

Hi Vidhuran, sorry about the delay here, we've been busy getting releases together.

Thank you for the patch, I've just left some comments in github for some minor changes.

Please could you also rebase it against latest master when you update it?

Then if you re-request review to me, we should be able to land it quite quickly.
Attachment #8723529 - Flags: review?(standard8)
(Assignee)

Comment 5

2 years ago
Updated the patch based on review comments. Requesting another review.
(Assignee)

Updated

2 years ago
Attachment #8723529 - Flags: review?(standard8)
(Reporter)

Comment 6

2 years ago
Comment on attachment 8723529 [details] [review]
[loop] Vidhuran:bug1249311-ftu-unittests > mozilla:master

That's great, thank you!
Attachment #8723529 - Flags: review?(standard8) → review+
(Reporter)

Comment 7

2 years ago
https://github.com/mozilla/loop/commit/c158dc119dfe32a9ed2429229b8aac42781d8ddf
Status: NEW → RESOLVED
Iteration: --- → 47.3 - Mar 7
Last Resolved: 2 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.