Closed
Bug 1249312
Opened 9 years ago
Closed 9 years ago
Ensure Accelerated Canvas on Mac happens only on 10.7 or later
Categories
(Core :: Graphics, defect)
Tracking
()
RESOLVED
FIXED
mozilla47
People
(Reporter: mchang, Assigned: mchang)
References
Details
(Whiteboard: gfx-noted,regression)
Attachments
(1 file)
58 bytes,
text/x-review-board-request
|
mchang
:
review+
lizzard
:
approval-mozilla-aurora+
Sylvestre
:
approval-mozilla-beta+
|
Details |
Due to bug 1244569 and 1246633, it seems like accelerated skia canvas breaks some things. From the daily today, we decided to disable accelerated skia canvas on OS X versions < 10.8
Assignee | ||
Updated•9 years ago
|
Assignee | ||
Comment 1•9 years ago
|
||
From https://dxr.mozilla.org/mozilla-central/source/gfx/thebes/gfxPlatformMac.cpp#433, we should not be enabling accelerated skia canvas on less than 10.7, but from bug 1244569, the user is reporting 10.6.8. Maybe we're not respecting accelerated canvas prefs somewhere, digging.
In other words, I have a feeling that UseAcceleratedCanvas and UseAcceleratedSkiaCanvas should not both exist.
Review commit: https://reviewboard.mozilla.org/r/35503/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/35503/
Attachment #8720899 -
Flags: review?(mchang)
Come to think of it, I don't know what was happening here: https://dxr.mozilla.org/mozilla-central/source/gfx/layers/composite/LayerManagerComposite.cpp#1470 - were we forcing accelerated CG somehow?
Assignee | ||
Comment 6•9 years ago
|
||
Comment on attachment 8720899 [details]
MozReview Request: Bug 1249312: UseAcceleratedCanvas on Mac should really be UseAcceleratedSkiaCanvas. r?mchang
https://reviewboard.mozilla.org/r/35503/#review32189
Attachment #8720899 -
Flags: review?(mchang) → review+
Updated•9 years ago
|
Summary: Disable accelerated Canvas on OS X versions < 10.8 → Disable accelerated Skia Canvas on OS X versions < 10.8, and accelerated CG canvas always
Assignee | ||
Comment 7•9 years ago
|
||
We're still unsure if the google maps problem in bug 1246633 is strictly related to 10.7 as someone reproduced it on 10.10.
Summary: Disable accelerated Skia Canvas on OS X versions < 10.8, and accelerated CG canvas always → Ensure Accelerated Canvas on Mac happens only on 10.7 or later
Assignee | ||
Updated•9 years ago
|
status-firefox44:
--- → affected
status-firefox45:
--- → affected
status-firefox46:
--- → affected
status-firefox47:
--- → affected
Assignee | ||
Comment 9•9 years ago
|
||
Successful try - https://treeherder.mozilla.org/#/jobs?repo=try&revision=31f2c5e20ce8
Comment 10•9 years ago
|
||
Comment 11•9 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla47
Assignee | ||
Comment 12•9 years ago
|
||
Comment on attachment 8720899 [details]
MozReview Request: Bug 1249312: UseAcceleratedCanvas on Mac should really be UseAcceleratedSkiaCanvas. r?mchang
Approval Request Comment
[Feature/regressing bug #]: bug 1150944, accelerated canvas on OS X
[User impact if declined]: Graphic artifacts such as bug 1244569
[Describe test coverage new/current, TreeHerder]: Manual, treeherder
[Risks and why]: Low - Accelerated canvas was only supposed to be enabled on 10.7 or higher, but there was a bug in the check where lower versions such as 10.6 would actually enable accelerated canvas.
[String/UUID change made/needed]: None
Attachment #8720899 -
Flags: approval-mozilla-beta?
Attachment #8720899 -
Flags: approval-mozilla-aurora?
Comment 13•9 years ago
|
||
Tracking since this is a fairly recent regression (shipped with 42)
Comment 14•9 years ago
|
||
Comment on attachment 8720899 [details]
MozReview Request: Bug 1249312: UseAcceleratedCanvas on Mac should really be UseAcceleratedSkiaCanvas. r?mchang
Should prevent some issues on macs, please uplift to aurora
Attachment #8720899 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Comment 15•9 years ago
|
||
bugherder uplift |
Updated•9 years ago
|
Comment 16•9 years ago
|
||
Milan, do you confirm that we really want that in 45 & 45esr or this can ride the train? This is really late in the cycle.
thanks
Flags: needinfo?(milan)
Updated•9 years ago
|
I appreciate the lateness of the request. About 24% of our OS X user base is affected, and has had sub par canvas experience since this regression slipped in.
Before we do though - Mason, we would want bug 1249659 as well, right? This only deals with 10.6 systems, and it's bug 1249659 that also handles it for 10.7 ones.
Flags: needinfo?(milan) → needinfo?(mchang)
Assignee | ||
Comment 18•9 years ago
|
||
(In reply to Milan Sreckovic [:milan] from comment #17)
> I appreciate the lateness of the request. About 24% of our OS X user base
> is affected, and has had sub par canvas experience since this regression
> slipped in.
>
> Before we do though - Mason, we would want bug 1249659 as well, right? This
> only deals with 10.6 systems, and it's bug 1249659 that also handles it for
> 10.7 ones.
Correct, we probably want both this and bug 1249659. I was going to ask for beta uplift on bug 1249659 after this one lands.
Flags: needinfo?(mchang)
Comment 19•9 years ago
|
||
Comment on attachment 8720899 [details]
MozReview Request: Bug 1249312: UseAcceleratedCanvas on Mac should really be UseAcceleratedSkiaCanvas. r?mchang
I am very unhappy to see this kind of uplift request that late in the cycle.
Next time, please be on top of your features, Bug 1244569 has been reported a month ago :/
Taking it for the only reason that 45 is an ESR.
Attachment #8720899 -
Flags: approval-mozilla-beta? → approval-mozilla-beta+
Comment 20•9 years ago
|
||
bugherder uplift |
You need to log in
before you can comment on or make changes to this bug.
Description
•