Closed Bug 1249313 Opened 7 years ago Closed 7 years ago

MediaEngineRemoteVideoSource Shutdown should not shut down Cameras()

Categories

(Core :: WebRTC: Audio/Video, defect, P1)

Product:
Core
Component:
WebRTC: Audio/Video
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla47
Tracking Flags:
Tracking Status
firefox47 --- fixed
firefox49 --- fixed
Blocking Flags:
backlog webrtc/webaudio+

People

(Reporter: gcp, Assigned: jesup)

References

Details

Attachments

(1 file)

Don't shut down the entire Cameras IPC if a single source is shut down
1008 bytes, patch
jesup
: review+
Details | Diff | Splinter Review 
MediaEngineRemoteVideoSource::Shutdown currently calls the Shutdown function in CamerasChild. But we can have multiple active remote video sources, and shutting one down shouldn't tear down the entire subsystem. That can be done when MediaManager shuts down the respective backend.
gcp has a patch for this on that Try
Assignee: nobody → gpascutto
backlog: --- → webrtc/webaudio+
Rank: 16
Priority: -- → P1
Attachment #8722485 - Flags: review?(rjesup) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/b1b50935ab45f360774e75a4d814b2f9bf02d916
Bug 1249313 - Don't shut down the entire Cameras IPC if a single source is shut down. r=jesup
https://hg.mozilla.org/mozilla-central/rev/b1b50935ab45
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox47: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla47
backed out for making bug 1207431 worse
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
I've given up on this for now.
Assignee: gpascutto → nobody
Assignee: nobody → rjesup
Depends on: 1267600
https://hg.mozilla.org/mozilla-central/rev/cf13730eeda2
Status: REOPENED → RESOLVED
Closed: 7 years ago → 7 years ago
status-firefox49: --- → fixed
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.