1249313 - MediaEngineRemoteVideoSource Shutdown should not shut down Cameras()

Status: RESOLVED FIXED

(Core :: WebRTC: Audio/Video, defect, P1)

Description

[Gian-Carlo Pascutto [:gcp]]

MediaEngineRemoteVideoSource::Shutdown currently calls the Shutdown function in CamerasChild. But we can have multiple active remote video sources, and shutting one down shouldn't tear down the entire subsystem. That can be done when MediaManager shuts down the respective backend.

Comment 1

[Gian-Carlo Pascutto [:gcp]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=5e2d37e9729b

Comment 2

[Randell Jesup [:jesup] (needinfo me)]

gcp has a patch for this on that Try

Comment 3

[Gian-Carlo Pascutto [:gcp]]

Attachment: Don't shut down the entire Cameras IPC if a single source is shut down

Comment 4

[Gian-Carlo Pascutto [:gcp]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/b1b50935ab45f360774e75a4d814b2f9bf02d916
Bug 1249313 - Don't shut down the entire Cameras IPC if a single source is shut down. r=jesup

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/b1b50935ab45

Comment 6

[Pulsebot]

Backout:
https://hg.mozilla.org/mozilla-central/rev/e15383656900

Comment 7

[Carsten Book [:Tomcat]]

backed out for making bug 1207431 worse

Comment 8

[Gian-Carlo Pascutto [:gcp]]

I've given up on this for now.

Comment 9

[Randell Jesup [:jesup] (needinfo me)]

 https://treeherder.mozilla.org/#/jobs?repo=try&revision=d3b74079328c

Comment 10

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/cf13730eeda2

Comment 11

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/cf13730eeda2