Cleanup 'tabstray' Telemetry method

RESOLVED FIXED in Firefox 46

Status

()

defect
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: mfinkle, Unassigned)

Tracking

unspecified
Firefox 47
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox46 fixed, firefox47 fixed)

Details

Attachments

(1 attachment)

Simple swap. TABSTRAY is not a method. In the code, a user pressed a button. That's the method.
Attachment #8720842 - Flags: review?(liuche)
Comment on attachment 8720842 [details] [diff] [review]
cleanup-telemetry-method v0.1

Review of attachment 8720842 [details] [diff] [review]:
-----------------------------------------------------------------

I agree, it's technically not a TABSTRAY action, and could be classified as a button.

How much does it matter that the telemetry event of tapping on the tabs tray button conflicts with adding/removing a tab in tablet mode? I didn't find a better term that didn't conflict.

http://mxr.mozilla.org/mozilla-central/search?string=hidefirstrunpager&find=mobile/android/base&findi=&filter=^[^\0]*%24&hitlimit=&tree=mozilla-central
Attachment #8720842 - Flags: review?(liuche) → review+
(In reply to Chenxia Liu [:liuche] from comment #1)

> I agree, it's technically not a TABSTRAY action, and could be classified as
> a button.
> 
> How much does it matter that the telemetry event of tapping on the tabs tray
> button conflicts with adding/removing a tab in tablet mode? I didn't find a
> better term that didn't conflict.

I'm glad you're thinking about conflicts like this. I don't think we need to worry about the _exact_ button that caused the close in this case though.
Comment on attachment 8720842 [details] [diff] [review]
cleanup-telemetry-method v0.1

Approval Request Comment
[Feature/regressing bug #]: Bug 1208138
[User impact if declined]: Just cleaning up the telemetry
[Describe test coverage new/current, TreeHerder]:
[Risks and why]: Low risk cleanup patch
[String/UUID change made/needed]: None

Bug 1208138 uplift is requested for Fx46 and this patch should go along with it.
Attachment #8720842 - Flags: approval-mozilla-aurora?
https://hg.mozilla.org/mozilla-central/rev/06e2f969c46e
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 47
Marking affected for 46
Comment on attachment 8720842 [details] [diff] [review]
cleanup-telemetry-method v0.1

Telemetry fix, recent regression.
Attachment #8720842 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
has problems uplifting to aurora

grafting 329838:06e2f969c46e "Bug 1249314 - Cleanup 'tabstray' Telemetry method r=liuche"
merging mobile/android/base/java/org/mozilla/gecko/BrowserApp.java
merging mobile/android/base/java/org/mozilla/gecko/TelemetryContract.java
warning: conflicts while merging mobile/android/base/java/org/mozilla/gecko/TelemetryContract.java! (edit, then use 'hg resolve --mark')
abort: unresolved conflicts, can't continue
(use hg resolve and hg graft --continue)
Flags: needinfo?(mark.finkle)
You need to log in before you can comment on or make changes to this bug.