1249315 - Cannot select directory in "Select Add-on Directory or XPI File" dialog

Status: RESOLVED DUPLICATE of bug 1256246

(DevTools :: about:debugging, defect)

Description

[Michiel de Jong [:michielbdejong]]

Attachment: open-button-greyed-out.png

Selecting a directory and then clicking 'Open' will open that folder in the filepicker dialog, instead of selecting that directory as the one to open.

Workaround: select a random file inside the directory.

Maybe changing https://mxr.mozilla.org/mozilla-central/source/devtools/client/locales/en-US/aboutdebugging.properties#8 to say "Select manifest.json or XPI File" would make it easier for the user (but not sure how that would affect the way it works on Windows or Linux).

Comment 1

[Blake Winton (:bwinton) (:☕️)]

Is it possible to use the file-picker to select either a directory or a file?

Comment 2

[Michiel de Jong [:michielbdejong]]

IANAMD (I am not a Mac developer), but it looks like you can specify both the 'canChooseFiles' and 'canChooseDirectories' in https://developer.apple.com/library/mac/documentation/Cocoa/Reference/ApplicationKit/Classes/NSOpenPanel_Class/index.html - so if it's possible in Cocoa, I guess that means the OS supports it.

Comment 3

[Andy McKay]

Its probably the nsIFilePicker that's the problem as rhelmer describes here: https://bugzilla.mozilla.org/show_bug.cgi?id=1231129#c0

Comment 4

[Jan Keromnes [:janx]]

Alex, could you please have a look at this?

Comment 5

[Alexandre Poirot [:ochameau]]

I'm off next week. So I won't be able to look into this until Monday 14th.
You are welcome to contribute to addons.
Tweaking the localization string, as noted in bug 1231129 comment 4 would help a lot.

Comment 6

[Kumar McMillan [:kumar]]

> Maybe changing ... to say "Select manifest.json or XPI File" would make it easier for the user

I'm going to try this in bug 1256246

Comment 7

[Alexandre Poirot [:ochameau]]

Michiel, Can we consider this bug as a duplicate of bug 1256246 and close it?
Kumar changed the string to:
  Select Manifest File or Package (.xpi)

Comment 8

[Michiel de Jong [:michielbdejong]]

Yes, great!