124933 - Success indicator should distinguish between changing builtin object token and device token password

Status: RESOLVED WONTFIX

(Core Graveyard :: Security: UI, enhancement, P2)

Description

[John Unruh]

1.) Install a hardware token.
2.) Tasks>Privacy>Password>Change Password. 
3.) Change the password on the hardware token.
What happens: I get "Master Password successfully changed". This doesn't seem 
correct, since I didn't really change the master password.

Comment 1

[Stephane Saux]

Technically, the password for a token is also called the master password.

Maybe a better thing to do would be to change both the change master pwd and the
success dialog to say something like:

"Change Master Password for a device"

"Master Password for the device successfully changed"

for the latter message, we can go one step further and name the device (more work).

Comment 2

[John G. Myers]

Mass reassign ssaux bugs to nobody

Comment 3

[Nelson Bolyard (seldom reads bugmail)]

Mass change "Future" target milestone to "--" on bugs that now are assigned to
nobody.  Those targets reflected the prioritization of past PSM management.
Many of these should be marked invalid or wontfix, I think.

Comment 4

[timeless]

Attachment: i don't know if you can reach the failure cases, but this seems to be the general idea

would someone please send me a token device :)

Comment 5

[Kai Engert [:KaiE:]]

Bob, is this proposed change desirable from your point of view?

Comment 6

[Kai Engert [:KaiE:]]

This bug proposes to use different wording for changing the master password.

In particular it proposes, whenever the token name is different than "Builtin Object Token", the wording shall include "your device's" in addition to "master password".

Bob, what's your opinion? Good change or unnecessary?

Comment 7

[Robert Relyea]

You mean from the software token?

I don't have a problem with adding the term 'your device's, but I would use the call PK11_IsHW() to decide to use it. The builtin softoken isn't the only possible software device (there's one that is common for mac users that gives access to the mac keyring).

bob

Comment 8

[Robert Relyea]

Actually it would be better to give the token that the password was changed for rather than a vague "master password" or "your device".

bob

Comment 9

[Kai Engert [:KaiE:]]

Comment on attachment 329083 [details] [diff] [review]
i don't know if you can reach the failure cases, but this seems to be the general idea

r- , patch should get enhanced based on suggestions

Comment 10

[Dana Keeler (she/her) [:keeler]]

If this is really important to someone, I will assist them in fixing this bug, but otherwise I don't think it's worth the time to fix.