1249353 - Warnings about deprecated bootstrap primitives in treeherder

Status: VERIFIED FIXED

(Tree Management :: Treeherder, defect, P4)

Description

[William Lachance (:wlach)]

Seeing lots of error messages in the console when I load treeherder:

DropdownController is now deprecated. Use UibDropdownController instead.
dropdown-toggle is now deprecated. Use uib-dropdown-toggle instead.
...

Various primitives in the treeherder frontend need to be updated for the latest version of angular bootstrap:

http://angular-ui.github.io/bootstrap/

This probably wouldn't be a bad good first bug for someone to take on, though I don't know if we want to wait to fix it. CC'ing a few people who have worked on some frontend stuff to see if they're interested in a quick bug. Feel free to grab it if you fancy a diversion. I'll do it if there are no takers. :)

Comment 1

[Jonathan French (:jfrench)]

No probs, I'll do this.

Comment 2

[Jonathan French (:jfrench)]

Attachment: PR 1311

Autolander didn't seem to automatically attach the PR so doing it manually. Feel free to obsolete this attachment if Autolander does do it.

Comment 3

[Treeherder GitHub Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/8cc12b16fbb1c629ea851ea46c4b34e0dd7d8cb7
Bug 1249353 - Update deprecated angular directives to uib

Comment 4

[William Lachance (:wlach)]

Comment on attachment 8721691 [details] [review]
PR 1311

Awesome, thank you! Yes, it seems like some of the github hooks aren't operating as they should be these days (which includes Autoland). I'll dig into it if the problems persist, I suspect that the problem is on github's end since AFAIK nothing changed in our services and things still work sometimes.

Comment 5

[Cameron Dawson [:camd]]

Thanks Jon!  This has been annoying for a loooong time....   You're a rock-star, bud.  :)

Comment 6

[Jonathan French (:jfrench)]

Verified fixed on production. :)