Closed Bug 1249395 Opened 8 years ago Closed 8 years ago

Failure summary comes up empty on first job clicked

Categories

(Tree Management :: Treeherder, defect, P1)

defect

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: wlach, Assigned: wlach)

References

Details

Attachments

(1 file)

47 bytes, text/x-github-pull-request
camd
: review+
Details | Review
Noticed this on prod deploy. This is due to an oversight in bug 1239779
Blocks: 1239779
Attached file PR
Can you give this a fast review :camd? The problem is that there's a race condition with displaying the failure summary: the failure summary has update logic which is only triggered when (1) the tab is first loaded or (2) the user explicitly switches to it, and the patch in bug 1239779 made it so we only switch to the failure summary *after* we've loaded the tab for the first time.

There are a bunch of things we should do to clean this up, but this fixes the immediate problems.
Attachment #8720962 - Flags: review?(cdawson)
I merged this in because I didn't think we wanted to wait on it, but I'd still appreciate a review.
Comment on attachment 8720962 [details] [review]
PR

This solution looks good to me.  Improves efficiency, too, by saving the ajax call if the job is not a success.  Thanks for fixing this.  :)
Attachment #8720962 - Flags: review?(cdawson) → review+
Status: NEW → RESOLVED
Closed: 8 years ago
Priority: -- → P1
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: