Closed Bug 1249453 Opened 8 years ago Closed 8 years ago

Add arrows from parent to children in census trees

Categories

(DevTools :: Memory, defect, P2)

defect

Tracking

(firefox47 fixed)

RESOLVED FIXED
Firefox 47
Tracking Status
firefox47 --- fixed

People

(Reporter: fitzgen, Assigned: fitzgen)

References

(Blocks 1 open bug)

Details

Attachments

(3 files, 1 obsolete file)

Similar to zoom profiler: http://www.rotateright.com/wp-content/uploads/screenshots/call-tree-screenshot.png

Makes it more clear / intuitive what is going on when inverting trees.
See Also: → 1249476
Fixes the test failures surfaced in the last try push.
Attachment #8721353 - Flags: review?(jsantell)
Attachment #8721059 - Attachment is obsolete: true
Attachment #8721059 - Flags: review?(jsantell)
Comment on attachment 8721353 [details] [diff] [review]
Add arrows from parent to children in census trees

Review of attachment 8721353 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, the arrows seem a bit weird to me, I'd have Helen check it out, or at the very least handle the arrows in CSS so we can swap them out with an icon/image in the future

::: devtools/client/memory/components/census-tree-item.js
@@ +47,5 @@
> +    let pointer;
> +    if (inverted && depth > 0) {
> +      pointer = dom.span({ className: "children-pointer" }, "↖");
> +    } else if (!inverted && item.children && item.children.length) {
> +      pointer = dom.span({ className: "children-pointer" }, "↘");

I think I'd prefer the addition of a unique class name (for inverted state) so we could do this with pseudo elements in CSS, especially as this would make it easier to add an icon better than this UTF-8 arrow
Attachment #8721353 - Flags: review?(jsantell) → review+
(In reply to Jordan Santell [:jsantell] [@jsantell] (Please needinfo) from comment #6)

Filed bug 1249803 for using icon and/or CSS pseudo elements for the arrows.
Has STR: --- → irrelevant
Priority: -- → P2
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/7e648af1885d
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 47
Successfully reproduce this bug on Nightly 47.0a1 (2016-02-18) (Build ID: 20160218030349) on Linux, 64 Bit

This Bug is now verified as fixed on Latest Firefox Nightly 48.0a1 (2016-04-06)

Build ID: 20160406030221
OS: Linux 3.19.0-58-generic x86-64
Mozilla/5.0 (X11; Linux x86_64; rv:48.0) Gecko/20100101 Firefox/48.0
QA Whiteboard: [bugday-20160406]
I have reproduced this bug on Nightly 47.0a1 (2016-02-18)  on Windows 7 , 64 Bit

This Bug is verified as fixed on Latest Firefox Nightly 

Build ID   20161006030208
User Agent Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:52.0) Gecko/20100101 Firefox/52.0
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: