Closed Bug 1249483 Opened 6 years ago Closed 6 years ago

Don't clear RGBX readpixels' X channel to 1.0 ourselves

Categories

(Core :: Canvas: WebGL, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla47
Tracking Status
firefox47 --- fixed

People

(Reporter: jgilbert, Assigned: jgilbert)

Details

Attachments

(1 file)

We should probably not bother doing this.

In particular, we will not be able to do this in WebGL 2 for PBOs.

I believe this was an ancient driver workaround, but I can't find what it was for exactly.

The Try run is clean, though this doesn't have Android runs, and has spurious unrelated errors:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=77a7e32d7999
Attachment #8721089 - Flags: review?(jmuizelaar)
(In reply to Jeff Gilbert [:jgilbert] from comment #0)
> Created attachment 8721089 [details] [diff] [review]
> 0001-Stop-filling-A-with-1.0-on-readback-from-no-alpha.patch
> 
> We should probably not bother doing this.
> 
> In particular, we will not be able to do this in WebGL 2 for PBOs.
> 
> I believe this was an ancient driver workaround, but I can't find what it
> was for exactly.
> 
> The Try run is clean, though this doesn't have Android runs, and has
> spurious unrelated errors:
> https://treeherder.mozilla.org/#/jobs?repo=try&revision=77a7e32d7999

This came from:
https://bugzilla.mozilla.org/show_bug.cgi?id=912196#c36

Which is relatively recent. Can you remember why you wrote that?
Flags: needinfo?(jgilbert)
(In reply to Jeff Muizelaar [:jrmuizel] from comment #1)
> (In reply to Jeff Gilbert [:jgilbert] from comment #0)
> > Created attachment 8721089 [details] [diff] [review]
> > 0001-Stop-filling-A-with-1.0-on-readback-from-no-alpha.patch
> > 
> > We should probably not bother doing this.
> > 
> > In particular, we will not be able to do this in WebGL 2 for PBOs.
> > 
> > I believe this was an ancient driver workaround, but I can't find what it
> > was for exactly.
> > 
> > The Try run is clean, though this doesn't have Android runs, and has
> > spurious unrelated errors:
> > https://treeherder.mozilla.org/#/jobs?repo=try&revision=77a7e32d7999
> 
> This came from:
> https://bugzilla.mozilla.org/show_bug.cgi?id=912196#c36
> 
> Which is relatively recent. Can you remember why you wrote that?

This is not where it originally came from. You can see in the cset that I'm really just moving code around.
Flags: needinfo?(jgilbert) → needinfo?(jmuizelaar)
Comment on attachment 8721089 [details] [diff] [review]
0001-Stop-filling-A-with-1.0-on-readback-from-no-alpha.patch

Review of attachment 8721089 [details] [diff] [review]:
-----------------------------------------------------------------

Right.
Attachment #8721089 - Flags: review?(jmuizelaar) → review+
Flags: needinfo?(jmuizelaar)
https://hg.mozilla.org/mozilla-central/rev/cf3f2dc292d5
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla47
You need to log in before you can comment on or make changes to this bug.