Closed
Bug 1249513
Opened 5 years ago
Closed 5 years ago
OdinMonkey: MIPS: Refactor thunkWithPatch via relative branch
Categories
(Core :: JavaScript Engine: JIT, defect)
Tracking
()
RESOLVED
FIXED
mozilla47
Tracking | Status | |
---|---|---|
firefox47 | --- | fixed |
People
(Reporter: hev, Assigned: hev)
References
Details
Attachments
(2 files)
2.09 KB,
patch
|
luke
:
review+
|
Details | Diff | Splinter Review |
1.36 KB,
patch
|
luke
:
review+
|
Details | Diff | Splinter Review |
Assignee | ||
Comment 1•5 years ago
|
||
Attachment #8721137 -
Flags: review?(luke)
Assignee | ||
Comment 2•5 years ago
|
||
Attachment #8721138 -
Flags: review?(luke)
![]() |
||
Comment 3•5 years ago
|
||
Comment on attachment 8721137 [details] [diff] [review] 0001-OdinMonkey-MIPS-Refactor-thunkWithPatch-via-relative.patch Review of attachment 8721137 [details] [diff] [review]: ----------------------------------------------------------------- Awesome, thanks so much!
Attachment #8721137 -
Flags: review?(luke) → review+
![]() |
||
Comment 4•5 years ago
|
||
Comment on attachment 8721138 [details] [diff] [review] 0002-OdinMonkey-MIPS-Clean-up-long-jump-patching-in-asm.j.patch Review of attachment 8721138 [details] [diff] [review]: ----------------------------------------------------------------- I believe you can now also remove StaticLinkData::InternalLink::Kind, InternalLink's ctor, and InternalLink::isRawPointerPatch :)
Attachment #8721138 -
Flags: review?(luke) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/23b8141fddd4 https://hg.mozilla.org/integration/mozilla-inbound/rev/ac7aa6014f38
Comment 6•5 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/23b8141fddd4 https://hg.mozilla.org/mozilla-central/rev/ac7aa6014f38
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox47:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla47
You need to log in
before you can comment on or make changes to this bug.
Description
•