1249513 - OdinMonkey: MIPS: Refactor thunkWithPatch via relative branch

Status: RESOLVED FIXED

(Core :: JavaScript Engine: JIT, defect)

Description

[hev [:hev]]

See https://bugzilla.mozilla.org/show_bug.cgi?id=1248859#c16

Comment 1

[hev [:hev]]

Attachment: 0001-OdinMonkey-MIPS-Refactor-thunkWithPatch-via-relative.patch

Comment 2

[hev [:hev]]

Attachment: 0002-OdinMonkey-MIPS-Clean-up-long-jump-patching-in-asm.j.patch

Comment 3

[Luke Wagner [:luke]]

Comment on attachment 8721137 [details] [diff] [review]
0001-OdinMonkey-MIPS-Refactor-thunkWithPatch-via-relative.patch

Review of attachment 8721137 [details] [diff] [review]:
-----------------------------------------------------------------

Awesome, thanks so much!

Comment 4

[Luke Wagner [:luke]]

Comment on attachment 8721138 [details] [diff] [review]
0002-OdinMonkey-MIPS-Clean-up-long-jump-patching-in-asm.j.patch

Review of attachment 8721138 [details] [diff] [review]:
-----------------------------------------------------------------

I believe you can now also remove StaticLinkData::InternalLink::Kind, InternalLink's ctor, and InternalLink::isRawPointerPatch :)

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/23b8141fddd4
https://hg.mozilla.org/integration/mozilla-inbound/rev/ac7aa6014f38

Comment 6

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/23b8141fddd4
https://hg.mozilla.org/mozilla-central/rev/ac7aa6014f38